-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #333: Change exported GPX filenames to 'YYYY-MM-DD_hh-mm-ss_OSMTracker.gpx' #482
base: develop
Are you sure you want to change the base?
Conversation
…_OSMTracker.gpx'
Does it also address #470 ? |
Hi @Kevin-Salazar-itcr thank a lot for this PR! Feel free to review other bugs that I tagged as "Good first issue". Others PR will be more than welcome 👍 @jer194, since you are interested by this bug, feel free to try the APK with this fix. You can find the "zip artifact" containing the APK at the bottom of this page: https://github.com/labexp/osmtracker-android/actions/runs/12237475785?pr=482 Once tested, I will merge this PR as the code changes looks good to me. |
Hi both, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Kevin-Salazar-itcr You changed the code of ExportToTempFileTask, but this code is only used to export a track in a temp folder before sending the track to OpenStreetMap. So you need to check code of ExportToStorageTask
Also, as of today, when I export a track, I get:
- A folder
2024-12-10_12-24-58
(this is OK)- My GPX file
2024-12-10_12-24-58_2024-12-10_12-24-58.gpx
(this needs to be changed
- My GPX file
Can you please try to change this. And test it via the App. Long click on a track > Export as GPX. The track is exported in Document folder > osmtracker
Hi @Binnette, which of these options do you have selected, because I think that instead of an error it is a preference, since it may be that you have selected name and date, and since the name is the same as the date, it is duplicated. |
I tried it with the other options and it doesn't duplicate, only in that case it duplicates when the track name is not changed and remains the same as the creation date |
Update GPX export filenames to follow the format YYYY-MM-DD_hh-mm-ss_OSMTracker.gpx for better organization and clarity.