Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #333: Change exported GPX filenames to 'YYYY-MM-DD_hh-mm-ss_OSMTracker.gpx' #482

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Kevin-Salazar-itcr
Copy link

Update GPX export filenames to follow the format YYYY-MM-DD_hh-mm-ss_OSMTracker.gpx for better organization and clarity.

@jer194
Copy link

jer194 commented Dec 9, 2024

Does it also address #470 ?
I.e.: preset could be 'OSMTracker', but it can be changed to any user specified string?

@Kevin-Salazar-itcr
Copy link
Author

Kevin-Salazar-itcr commented Dec 9, 2024

Hi @jer194, yes it does, since @Binnette commented it's a duplicated of #333.

This solution simply takes the track name and appends "_OSMTracker" label to the end. Allowing users to provide a custom label is a feature that could be implemented later.

@Binnette
Copy link
Collaborator

Hi @Kevin-Salazar-itcr thank a lot for this PR! Feel free to review other bugs that I tagged as "Good first issue". Others PR will be more than welcome 👍

@jer194, since you are interested by this bug, feel free to try the APK with this fix. You can find the "zip artifact" containing the APK at the bottom of this page: https://github.com/labexp/osmtracker-android/actions/runs/12237475785?pr=482

Once tested, I will merge this PR as the code changes looks good to me.

@jer194
Copy link

jer194 commented Dec 10, 2024

Hi both,
the provided apk does not include the change in the PR from #483,
that's what I am really after :-)
Thanks - Jakob.

Copy link
Collaborator

@Binnette Binnette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kevin-Salazar-itcr You changed the code of ExportToTempFileTask, but this code is only used to export a track in a temp folder before sending the track to OpenStreetMap. So you need to check code of ExportToStorageTask

Also, as of today, when I export a track, I get:

  • A folder 2024-12-10_12-24-58 (this is OK)
    • My GPX file 2024-12-10_12-24-58_2024-12-10_12-24-58.gpx (this needs to be changed

Can you please try to change this. And test it via the App. Long click on a track > Export as GPX. The track is exported in Document folder > osmtracker

@Andyporras
Copy link

Andyporras commented Dec 11, 2024

Hi @Binnette, which of these options do you have selected, because I think that instead of an error it is a preference, since it may be that you have selected name and date, and since the name is the same as the date, it is duplicated.

Screenshot_2024-12-11-09-06-32-572_net.osmtracker.jpg

@Andyporras
Copy link

Andyporras commented Dec 11, 2024

I tried it with the other options and it doesn't duplicate, only in that case it duplicates when the track name is not changed and remains the same as the creation date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants