Fix DividerItemDecoration duplication and GPX export issues (#479 #480) #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion in RecyclerView setup
…torage - Extracted permission handling logic into a reusable method. - Added support for Android R+ to avoid unnecessary permission requests. - Displayed a rationale dialog when permission is not granted.
|
Hi @miltonials can you make a need PR to propose better messages for :
In fact, I don't like the "we need". Instead should be "OSMTracker needs". Also can you please try to make shorter sentences ? So maybe:
Or maybe:
Or even more simple, just one message "OSMTracker needs storage access to perform this action" What do you think ? If you can please try/test to see what solution fit the best 🙏 Thanks a lot, for fixing these old strings 😉👍 |
|
Hi @Binnette! 👋🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This PR addresses issues #479 and #480
Modifications
DividerItemDecoration is added more than once #479
Added a new check to prevent adding a divider multiple times.
"Export as GPX" btn in track details is not working #480
The request of storage permission was moved to a new private reusable method
writeExternalStoragePermissionGranted().His implementation adds a new check to validate new android SDKs and a new
AlertDialogif the permission is not granted.Finally, coded strings have been replaced by @string resources to improve localization and maintenance.