Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow editing/deleting waypoints #171

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

icrf2000
Copy link
Contributor

@icrf2000 icrf2000 commented Nov 7, 2018

This PR allows editing or deleting existing waypoints. Tap on a waypoint in the list to open a dialogue to edit/delete.

I also slightly modified the layout of the waypoint list to accommodate for longer waypoint names.

@icrf2000 icrf2000 changed the title Hz edit waypoints allow editing waypoint text/name Nov 7, 2018
@icrf2000 icrf2000 changed the title allow editing waypoint text/name allow editing/deleting waypoints Nov 21, 2018
@icrf2000 icrf2000 mentioned this pull request Nov 23, 2018
@aton1698
Copy link
Contributor

Hi, thanks for your contribuiton!
This improvement looks really good, I was testing it and the functionality is great. But there are some things about the desing. First, could be great to use the already existing strings, and the dialog which appears to edit the waypionts could be the same used in others app functionalities, like in the settings options (pop ups).

It would be awesome if you could make the changes, otherwise when we have a little bit of time we will try to fix it.

Also, you can change the target branch to the develop branch? This because we're using gitflow.

@icrf2000 icrf2000 changed the base branch from master to develop January 15, 2019 13:39
@icrf2000
Copy link
Contributor Author

icrf2000 commented Jan 15, 2019

Ok, changed to develop.

For the design, I don't know whether I'm able to make it more beautiful. I saw that other parts of the app also use the alertdialog. I know it is deprecated, but I didn't use the more recent technologies, fragments etc. so far and have no experience with them. When I find time, I will look into it a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants