Skip to content

feat: upgraded to node v24 #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: upgraded to node v24 #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4b3bfb
feat: upgraded to node v24
demeyerthom Sep 16, 2025
ce69b2d
feat: code review changes
demeyerthom Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/open-items-teach.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@labdigital/commercetools-mock": minor
---

Updated node version to 24
2 changes: 1 addition & 1 deletion .github/workflows/ci-cd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
if: github.event_name == 'push' && github.ref == 'refs/heads/main' || github.event_name == 'pull_request'
strategy:
matrix:
node: ["18.x", "20.x", "22.x"]
node: ["18.x", "20.x", "22.x", "24.x"]
os: [ubuntu-latest, windows-latest, macOS-latest]
runs-on: ${{ matrix.os }}
env:
Expand Down
2 changes: 2 additions & 0 deletions .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
nodejs 24.1
pnpm 10.8.0
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
FROM node:18-alpine AS builder
ENV PNPM_VERSION=9.0.2
FROM node:24-alpine AS builder
ENV PNPM_VERSION=10.11

RUN corepack enable && \
corepack prepare pnpm@${PNPM_VERSION} --activate && \
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"fishery": "2.2.3",
"supertest": "7.1.0",
"timekeeper": "2.3.1",
"tsdown": "^0.9.9",
"tsdown": "0.15.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsdown doesn't support nodejs 18 anymore since 0.13.0. That's why the build is breaking now?

See: https://github.com/rolldown/tsdown/releases/tag/v0.13.0

"typescript": "5.8.3",
"vitest": "3.1.1"
},
Expand Down
605 changes: 189 additions & 416 deletions pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

Empty file removed src/.env
View file
Open in desktop
Empty file.
Loading