Skip to content

Changed Table Sort Buttons#631

Merged
isralduke merged 1 commit intomainfrom
table-sort-buttons
Apr 2, 2025
Merged

Changed Table Sort Buttons#631
isralduke merged 1 commit intomainfrom
table-sort-buttons

Conversation

@isralduke
Copy link
Contributor

@isralduke isralduke commented Apr 2, 2025 •
edited
Loading

This PR:

  • Changes <a> elements into <button> elements for the table sorting controls
  • this improves the accessibility of the table sorting controls by using elements which are more semantically appropriate

@isralduke isralduke requested a review from james-alt April 2, 2025 19:46
@isralduke isralduke self-assigned this Apr 2, 2025
@isralduke isralduke marked this pull request as ready for review April 2, 2025 19:56
@isralduke isralduke requested a review from a team as a code owner April 2, 2025 19:56
james-alt
james-alt approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@james-alt james-alt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@isralduke isralduke merged commit 5e18ffe into main Apr 2, 2025
5 checks passed
@isralduke isralduke deleted the table-sort-buttons branch April 2, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@james-alt james-alt james-alt approved these changes

Assignees

@isralduke isralduke

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@isralduke @james-alt