Conversation
frogpad7
reviewed
Jun 3, 2024
Contributor
frogpad7
left a comment
frogpad7
left a comment
There was a problem hiding this comment.
Find it weird the disabled buttons do not change between modes.
Linked list items look strange when pressed (instead of remaining similar to their hover style).
Popovers and tooltips are not readable in dark-mode.
Large Progress Indicator arrow buttons press differently than other similar colored buttons.
Not sure if the "Skip Link" should be different in dark mode.
Button Tabs are broken in dark mode.
Warning Toast text is too bright.
Form Validation coloration is too dark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds dark mode to Pelican 2.