Repository navigation
feat(tabs): close sidebar and top-strip tabs with middle-click - #1217
Open
alihandroid wants to merge 1 commit into
Open
alihandroid wants to merge 1 commit into
alihandroid wants to merge 1 commit into
Conversation
alihandroid
force-pushed
the
feat/middle-click-close-tabs
branch
from
October 23, 2026 13:59
ec76d0d to
5f04d40
Compare
alihandroid
force-pushed
the
feat/middle-click-close-tabs
branch
from
October 23, 2026 14:03
5f04d40 to
f97e59d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1204.
Problem
Terminal tabs can be closed through the hover close button, context menu, or keyboard shortcut, but not by middle-clicking their sidebar row or top-strip chip. Editor file tabs already support middle-click closure.
Changes
Handle middle-button presses on tab rows in the left sidebar and tab chips in the top strip.
Both handlers use the existing
close_tabpath, retaining close confirmations and unsaved-file protection. They stop event propagation so the press does not reach underlying controls.Add a GPUI event-dispatch regression covering both tab-bar positions. It checks that middle-clicking an inactive tab removes only that tab and leaves the active tab unchanged. Update the Unreleased changelog.
Validation
cargo test --locked -p tty7 --bin tty7-app: 2,549 passed, 2 ignored, including the new middle-click regression covering both tab-bar positions.cargo fmt --all -- --check: passed.bash .github/scripts/check-host-boundary.sh: passed.git diff --check: passed.cargo run --bin tty7-app; local manual testing confirmed the requested behavior.Windows and Linux behavior has not been manually verified.