Allow using secret injection on env vars, e.g. using vault-env #248
+74
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafael da Fonseca <[email protected]>
rsafonseca
force-pushed
the
use_env_vars
branch
from
7a1839e to
c160f62
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 32 32
Lines 18609 18609
=====================================
Misses 18609 18609 ☔ View full report in Codecov by Sentry. |
rsafonseca
force-pushed
the
use_env_vars
branch
from
b6bb509 to
afbc0c2
Compare
Signed-off-by: Rafael da Fonseca <[email protected]>
rsafonseca
force-pushed
the
use_env_vars
branch
from
afbc0c2 to
4bb0a9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change doesn't impact existing configurations, but it now allows to pass arbitrary values for database credentials as env variables.
This allows for example to use secret injection such as provided by vault-env