Adapt to adxl connection auto release feature

[ascend-direct-dev]

Description

Type of Change

• Types
  • Bug fix
  • New feature
    • Transfer Engine
    • Mooncake Store
    • Mooncake EP
    • Integration
    • P2P Store
    • Python Wheel
  • Breaking change
  • CI/CD
  • Documentation update
  • Other

How Has This Been Tested?

compile in ascend platform, and run some tests file

Checklist

• I have performed a self-review of my own code.
• I have updated the documentation.
• I have added tests to prove my changes are effective.

[gemini-code-assist]

Summary of Changes

Hello @ascend-direct-dev, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces additional logging throughout the data transfer mechanisms within the Mooncake store. The primary goal is to improve the diagnostic capabilities and operational visibility by recording the initiation and completion of batch retrieval and transfer submission processes, as well as detailed parameters for individual transfer engine operations.

Highlights

• Enhanced Logging for Data Transfers: Informational log statements have been added to key functions within the Client and TransferSubmitter classes to provide better visibility into data transfer and batch retrieval operations.
• Detailed Transfer Submission Logs: New logs now capture details like source, target offset, length, and segment during the submission of transfer engine operations, aiding in debugging complex data flows.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds several LOG(INFO) statements to trace data transfer operations. While adding logging is useful for debugging, placing LOG(INFO) inside loops that can iterate many times (e.g., for batch operations or multi-slice objects) can lead to excessive log volume in production, potentially impacting performance. My feedback focuses on changing these logs to a more appropriate verbose logging level, such as VLOG, which can be dynamically enabled for debugging without causing log spam under normal operation.

[ascend-direct-dev]

/gemini review

[gemini-code-assist]

Code Review

This pull request adapts the Ascend Direct Transport to a new 'auto release' feature in the ADXL library and introduces a retry mechanism for transfers. My review focuses on improving debuggability and code clarity. I've suggested re-instating error logging in the destructor for Disconnect and DeregisterMem calls, as logging failures is crucial for diagnosing shutdown issues. Additionally, I've recommended replacing a hardcoded retry count with a named constant to enhance maintainability. The refactoring and the new retry logic are well-implemented.

[ascend-direct-dev]

@alogfans please review