Skip to content

Conversation

@rolljee
Copy link
Member

@rolljee rolljee commented Dec 2, 2025

Overview

bump deps, pre-release it in order to be compatible with node js 24

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 4509 to 4511
"engines": {
"node": "^18.17.0 || >=20.5.0"
}
},
"node_modules/node-gyp/node_modules/brace-expansion": {
"version": "2.0.1",
"resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-2.0.1.tgz",
"integrity": "sha512-XnAIvQ8eM+kC6aULx6wuQiwVsnzsi9d3WxzV3FpWTGA19F621kwdbsAcFKXgKUHZWsy+mY6iL1sHTxWEFCytDA==",
"dev": true,
"license": "MIT",
"dependencies": {
"balanced-match": "^1.0.0"
}
},
"node_modules/node-gyp/node_modules/glob": {
"version": "10.4.5",
"resolved": "https://registry.npmjs.org/glob/-/glob-10.4.5.tgz",
"integrity": "sha512-7Bv8RF0k6xjo7d4A/PxYLbUCfb6c+Vpd2/mB2yRDlew7Jb5hEXiCD9ibfO7wpk8i4sevK6DFny9h7EYbM3/sHg==",
"dev": true,
"license": "ISC",
"dependencies": {
"foreground-child": "^3.1.0",
"jackspeak": "^3.1.2",
"minimatch": "^9.0.4",
"minipass": "^7.1.2",
"package-json-from-dist": "^1.0.0",
"path-scurry": "^1.11.1"
},
"bin": {
"glob": "dist/esm/bin.mjs"
},
"funding": {
"url": "https://github.com/sponsors/isaacs"
"node": "^20.17.0 || >=22.9.0"
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use supported Node version for node-gyp 12 in CI

node-gyp was bumped to 12.1.0 and its entry now declares engines: { "node": "^20.17.0 || >=22.9.0" } (package-lock.json). The pull_request workflow still installs Node 18 before running npm ci/npm run lint, so the CI job is installing this devDependency on an unsupported runtime; npm may reject the install or node-gyp may fail when invoked, breaking PR checks on Node 18. Please update the workflow to run on a Node version within the declared range or stick to a node-gyp release that supports Node 18.

Useful? React with 👍 / 👎.

@rolljee rolljee changed the title 1 dev Pre release Dec 2, 2025
@rolljee rolljee merged commit 919555d into beta Dec 2, 2025
5 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 2, 2025
## 1.4.0-beta.1 (2025-12-02)

* fix: missing deps to release ([6d92972](6d92972))
* fix: missing deps to release ([c90180b](c90180b))
* fix: missing deps to release ([91466d3](91466d3))
* Merge branch 'beta' into 1-dev ([594fad0](594fad0))
* Merge pull request #25 from kuzzleio/1-dev ([919555d](919555d)), closes [#25](#25)
* chore(license): Update LICENSE.md ([65924e6](65924e6))
* chore(license): Update LICENSE.md ([f88003f](f88003f))
* chore(lint): linting the app ([1b2a539](1b2a539))
* chore(runner): update runner version ([2253a4a](2253a4a))
* feat: bump deps ([2da3a53](2da3a53))
@kuzzle
Copy link

kuzzle commented Dec 2, 2025

🎉 This PR is included in version 1.4.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Dec 2, 2025
## 1.4.0 (2025-12-02)

* Merge branch 'beta' into 1-dev ([594fad0](594fad0))
* Merge pull request #25 from kuzzleio/1-dev ([919555d](919555d)), closes [#25](#25)
* Merge pull request #26 from kuzzleio/beta ([428c7e6](428c7e6)), closes [#26](#26)
* chore(license): Update LICENSE.md ([65924e6](65924e6))
* chore(license): Update LICENSE.md ([f88003f](f88003f))
* chore(lint): linting the app ([1b2a539](1b2a539))
* chore(release): 1.4.0-beta.1 [skip ci] ([935ff25](935ff25))
* chore(runner): update runner version ([2253a4a](2253a4a))
* fix: missing deps to release ([6d92972](6d92972))
* fix: missing deps to release ([c90180b](c90180b))
* fix: missing deps to release ([91466d3](91466d3))
* feat: bump deps ([2da3a53](2da3a53))
@kuzzle
Copy link

kuzzle commented Dec 2, 2025

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kuzzle kuzzle added the released label Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants