-
Notifications
You must be signed in to change notification settings - Fork 1
fix(qa): 자잘한 변경사항들 수정 #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
🔧 Electron Build Results✅ macOS
✅ Windows
This is an automated comment. |
hwanseok1014
approved these changes
Nov 19, 2025
Contributor
|
고생 너무 많으셨습니다. 화이팅 .... .! |
hwanseok1014
approved these changes
Nov 19, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분 header.tsx와 동일한 코드여서 혹시 커스텀 훅으로 분리 가능할까요..?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이제 api 등록할때 마지막 커밋 부분처럼 해주세요 그러면
src/preload/exposedInMainWorld.d.ts바뀌는거 신경안써도 됩니다!