-
Notifications
You must be signed in to change notification settings - Fork 1
[1팀] 프론트엔드 코드리뷰용 PR #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/1 components
- vite-plugin-svgr 설정을 프로젝트에 맞게 최적화 - exportType: default, icon: false, dimensions: false 설정 - expandProps: end로 props 전달 개선 - svgo 최적화 설정 (viewBox 유지, dimensions 제거) - CI 워크플로우에서 lockfile 동기화 문제 해결 - lockfile이 오래된 경우 자동 업데이트하도록 개선 - pnpm-lock.yaml 업데이트
feat: 다크모드 적용 및 디자인 컬러 수정
fix(qa): 자잘한 변경사항들 수정
fix(router): 로그인 플로우 수정
hotfix(build): 배포시 환경변수 추가
feat: 첫 온보딩 페이지 구현
feat(auth): 메일 리다이렉트 추가
feat: 대시보드(평균점수, 평균 점수 그래프, 이동거리) api 구현
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1팀] {거부기린} 프론트엔드 코드리뷰
💬 1팀이 고민하고 있는 부분
##💌 요청드리는 리뷰 방향
바쁘신 와중에 시간 내어 리뷰해주셔서 감사합니다.
편하게 피드백 부탁드립니다! 🥹