Potential fix for code scanning alert no. 1: Clear-text logging of sensitive information#7
Open
Yaketh (Kushmanmb) wants to merge 2 commits intomasterfrom
Open
Potential fix for code scanning alert no. 1: Clear-text logging of sensitive information#7Yaketh (Kushmanmb) wants to merge 2 commits intomasterfrom
Yaketh (Kushmanmb) wants to merge 2 commits intomasterfrom
Conversation
…nsitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/kushmanmb-org/bitcoin/security/code-scanning/1
In general, to fix clear-text logging of sensitive information, remove or redact sensitive fields before logging or printing, and only output the minimum non-sensitive data required for functionality. If a secret must be shown (e.g., to a human once), constrain it to explicit, documented, non-logged channels.
For this script, the best minimal fix is to stop including the plaintext password in the JSON output. The JSON output is presumably meant for automated consumption (e.g., tooling that wants username and
rpcauth), and therpcauthstring already contains the necessary information without exposing the raw password. We will therefore modify theif args.json:branch so thatodictcontains only non-sensitive fields: keepusernameandrpcauth, and drop thepasswordfield. The non-JSON branch can remain unchanged, since it is an interactive display where showing the password is expected behavior; if a stricter policy is desired, it could later be adjusted similarly.Concretely, in
share/rpcauth/rpcauth.py, around line 40, we will change the construction ofodictto excludepassword. No new imports or helper methods are required.Suggested fixes powered by Copilot Autofix. Review carefully before merging.