-
Notifications
You must be signed in to change notification settings - Fork 668
fix(connectors): correct connector registry stream name #5119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for .NET5 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
7328667
to
511ba95
Compare
Deploying eventstore with
|
Latest commit: |
511ba95
|
Status: | ✅ Deploy successful! |
Preview URL: | https://721f0311.eventstore.pages.dev |
Branch Preview URL: | https://yoeight-port-connectors-patc.eventstore.pages.dev |
w1am
previously approved these changes
May 28, 2025
hayley-jean
previously approved these changes
May 28, 2025
dbea2de
to
dcc4f40
Compare
w1am
previously approved these changes
May 28, 2025
hayley-jean
suggested changes
May 28, 2025
[Fact(Skip = "Isolate is conflicting with the one below")] | ||
public Task updates_snapshot_with_no_active_connectors() => Fixture.TestWithTimeout(async cancellator => { | ||
[Fact] | ||
public Task testing_something() => Fixture.TestWithTimeout(async cancellator => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could do with a more descriptive name 😄
Co-Authored-By: William Chong <[email protected]>
dcc4f40
to
938ca09
Compare
hayley-jean
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.