Skip to content

fix(connectors): correct connector registry stream name #5119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2025

Conversation

YoEight
Copy link
Contributor

@YoEight YoEight commented May 28, 2025

No description provided.

@YoEight YoEight requested a review from a team as a code owner May 28, 2025 02:32
@YoEight YoEight requested review from w1am and hayley-jean May 28, 2025 02:32
Copy link
Contributor

github-actions bot commented May 28, 2025

Qodana for .NET

5 new problems were found

Inspection name Severity Problems
Redundant using directive 🔶 Warning 4
Access to disposed captured variable 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@YoEight YoEight force-pushed the yoeight/port-connectors-patch branch from 7328667 to 511ba95 Compare May 28, 2025 03:05
Copy link

cloudflare-workers-and-pages bot commented May 28, 2025

Deploying eventstore with  Cloudflare Pages  Cloudflare Pages

Latest commit: 511ba95
Status: ✅  Deploy successful!
Preview URL: https://721f0311.eventstore.pages.dev
Branch Preview URL: https://yoeight-port-connectors-patc.eventstore.pages.dev

View logs

w1am
w1am previously approved these changes May 28, 2025
hayley-jean
hayley-jean previously approved these changes May 28, 2025
@YoEight YoEight dismissed stale reviews from hayley-jean and w1am via e8779a1 May 28, 2025 12:37
@YoEight YoEight force-pushed the yoeight/port-connectors-patch branch 2 times, most recently from dbea2de to dcc4f40 Compare May 28, 2025 14:02
@YoEight YoEight requested review from hayley-jean and w1am May 28, 2025 14:45
w1am
w1am previously approved these changes May 28, 2025
[Fact(Skip = "Isolate is conflicting with the one below")]
public Task updates_snapshot_with_no_active_connectors() => Fixture.TestWithTimeout(async cancellator => {
[Fact]
public Task testing_something() => Fixture.TestWithTimeout(async cancellator => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could do with a more descriptive name 😄

@YoEight YoEight force-pushed the yoeight/port-connectors-patch branch from dcc4f40 to 938ca09 Compare May 28, 2025 15:16
@YoEight YoEight merged commit 32a066c into master May 29, 2025
11 checks passed
@YoEight YoEight deleted the yoeight/port-connectors-patch branch May 29, 2025 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants