Naive POC: recycle buffers used for chunk cache #5037
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a naive proof-of-concept to recycle buffers for chunk caching in the transaction log.
- Updates to TFChunkManager and TFChunk to use fixed-size buffer allocation via a new IChunkCacheManager.
- Introduces two cache manager implementations (UnmanagedChunkCacheManager and PoolingChunkCacheManager) and adds corresponding XUnit tests.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/EventStore.Core/TransactionLog/Chunks/TFChunkManager.cs | Updated caching process comments and logic for fixed-size buffers. |
| src/EventStore.Core/TransactionLog/Chunks/TFChunk.cs | Replaced direct memory allocation/free calls with _cacheManager calls. |
| src/EventStore.Core/TransactionLog/Chunks/ChunkCacheManager.cs | Added new cache manager implementations using modern C# initialization patterns. |
| src/EventStore.Core.XUnit.Tests/TransactionLog/Chunks/PoolingChunkCacheManagerTests.cs | Added tests to verify allocation and reuse behaviour in pooling manager. |
timothycoleman
force-pushed
the
timothycoleman/pool-chunk-cache-buffers
branch
from
c8aec04 to
d9121d5
Compare
timothycoleman
force-pushed
the
timothycoleman/pool-chunk-cache-buffers
branch
2 times, most recently
from
801da12 to
fe7aa64
Compare
timothycoleman
force-pushed
the
timothycoleman/pool-chunk-cache-buffers
branch
from
fe7aa64 to
1c2f810
Compare
|
No need for this, the problem we encountered wasn't related to chunk allocations / fragmentation but windows Commit limit being exceeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: experiment