feat(clients): add GitHub Copilot CLI - #1
Merged
Conversation
0xPxt
marked this pull request as ready for review
May 20, 2026 12:36
0xPxt
force-pushed
the
feat/copilot-cli-support
branch
from
May 20, 2026 14:08
06a2021 to
329625f
Compare
emmanuelm41
self-requested a review
May 22, 2026 18:53
emmanuelm41
requested changes
May 22, 2026
emmanuelm41
left a comment
Member
There was a problem hiding this comment.
CI is failing @0xPxt. Can we fix it?
Member
Author
We need to merge Zondax/_workflows#90 |
Member
|
@0xPxt I think we can fix ci ? |
Member
Author
|
done @chcmedeiros @emmanuelm41 , passed cleanly after merging the _workflows PR |
chcmedeiros
self-requested a review
May 27, 2026 09:14
chcmedeiros
approved these changes
May 27, 2026
emmanuelm41
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Value
copilotfrom GitHub's standalone CLI can now register MCP servers via this installer.entryDefaultsslot instead of forking the writer.Technical
src/writer.ts—ServerEntrygains optionaltype?: stringandtools?: string[]fields. JSON writer passes them through unchanged.src/clients.ts—ClientDefgains optionalentryDefaults?: Partial<ServerEntry>. New 7th entry for GitHub Copilot CLI withentryDefaults: { type: 'local', tools: ['*'] },userPathhonouringCOPILOT_HOME,projectPath: null(Copilot CLI does not natively support a project-scoped config),detectInstalledchecks~/.copilot.src/index.ts—install()mergesclient.entryDefaultsinto the entry before writing; caller-supplied entry fields take precedence.src/__tests__/clients.test.ts— count 6→7; new assertions for Copilot'sprojectPath: null,entryDefaultsshape, and user-path behaviour with and withoutCOPILOT_HOME.src/__tests__/writer.test.ts— verifiestype+toolsflow through to JSON.README.md— supports-clients table row +COPILOT_HOMEenv var documented + note that Copilot entries are written withtype: "local"andtools: ["*"]per its schema.CI fix (incidental)
The original failure that surfaced this PR was unrelated to Copilot CLI: pnpm
latest(via mise) had silently rolled to 11.x, which removed theonlyBuiltDependencieskey inpnpm-workspace.yamland replaced it withallowBuilds. Migrated the workspace config to the new syntax.We did not mirror
kunobi-frontend's response to the same upstream change (#1459, #1497 there), which pinnedpnpm_version: "10"everywhere to stay on v10. Rationale:pnpm-workspace.yamlhas a single entry (esbuild) — migrating toallowBuildsis a one-line change with no maintenance footprint.Compatibility
@kunobi/mcplocally and running its full test suite (90/90 passing).Verification
pnpm check(biome) — cleanpnpm typecheck— cleanpnpm test— 41/41 passingpnpm build— cleanSequence
Part 1 of 3 for adding Copilot CLI to Kunobi. After this releases,
kunobi-ninja/mcpbumps its dep + ships a new version, thenZondax/kunobi-frontendupdates its settings UI.Related: Zondax/kunobi-frontend#1672 (parent issue), kunobi-ninja/mcp#6 (downstream README), Zondax/kunobi-frontend#1723 (UI side).
Blocked on: Zondax/_workflows#90 (publish job currently red until that lands and
v6is forwarded).