ci: publish the chart from the release tag, drop the helm_v* trigger - #51
Merged
Conversation
The chart now rides the operator's `v*` release tag instead of its own `helm_v*` tag: one tag ships the image, the signed CLI assets, the crate, the OS packages and the chart, so there is no second tag to remember and no window where a published chart's appVersion points at an image that was never built. Folding it into ci.yml replaces the standalone workflow's two guards with stronger ones that cost nothing: - the tag-vs-Chart.yaml version assertion is now `needs: version-consistency`, which already gates tag == workspace == Chart.yaml version + appVersion - the `docker manifest inspect zondax/kobe-operator:<appVersion>` probe is now `needs: publish`, i.e. the image was pushed in THIS run Tag-only (`if: startsWith(github.ref, 'refs/tags/v')`) — a push to main must not re-publish an already-released chart version, since chart versions are immutable in the registry. Prerequisite for the first push is unchanged: `zondax/kobe` must exist on Docker Hub and be public, and DOCKERHUB_TOKEN needs rights to push it.
This was referenced Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci.ymlas apublish-chartjob on thev*release tag.github/workflows/publish-chart.ymland itshelm_v*triggerWhy
The chart is versioned with the operator as of #50 (
Chart.yamlversion:==appVersion:== workspace version, enforced by the version gate). A separatehelm_v*tag then buys nothing and costs a step everyone can forget — and forgetting it is exactly how you end up with a chart whoseappVersionpoints at an image that was never built.One tag now ships everything: image, signed CLI assets, crate, OS packages, chart.
What the fold-in buys
The standalone workflow's two guards become dependency edges, which are strictly stronger:
helm_v<x>==Chart.yaml version:needs: version-consistency— already gates tag == workspace ==version:+appVersion:docker manifest inspect zondax/kobe-operator:<appVersion>needs: publish— the image was pushed in this runKept tag-only (
if: startsWith(github.ref, 'refs/tags/v')): a push to main must not try to re-publish an already-released chart version, since chart versions are immutable in the registry.Also worth noting: with the vendored
kobe-*.tgzgone from the tree (#45), thehelm push kobe-*.tgzglob is now unambiguous.Prerequisite (unchanged from #46)
zondax/kobedoes not exist on Docker Hub yet. The first push creates it private, andDOCKERHUB_TOKENneeds rights to create a repo underzondax. Create it public up front — a private chart repo fails closed for every consumer and surfaces as an auth error rather than a visibility one. Until that is done, this job is the one red square on an otherwise green release run; it does not block images, the GitHub release, crates.io, or the OS packages, which are independent jobs / a separaterelease: publishedcascade.Validation
ci.ymlparses;publish-chartresolves withneeds: [version-consistency, publish]and the tag-only condition. Not exercised end-to-end — the first real run is the v0.36.0 re-cut.