fix(daemon): drain accepted handlers on shutdown - #847
Merged
Conversation
jleni
force-pushed
the
fix/shutdown-handler-drain
branch
from
August 26, 2026 08:07
872042f to
4f0253c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JoinSetReliability coverage
RemoteCheck, sends an actualShutdown, requires its ACK while the client remains open, proves the accept loop is still draining, then requires the blocked response before loop completionValidation
-D warningscargo fmt --all -- --checkgit diff --checkmain(91a442c)CI follow-up
The first changed-line mutation run found two survivors that removed panic/error observability while leaving request behavior intact. The added success/panic/cancellation truth table rejects both prior survivors plus constant and branch-condition variants.
Follow-up boundary
Tokio
spawn_blockingclosures are non-cancellable and can outlive an aborted outer handler. This PR does not change that existing boundary; hardening blocking handler work is a separate follow-up.