Skip to content

docs(ci): note immutable-release dependency on the release job (#481) #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
emmanuelm41 wants to merge 1 commit into from
Closed

docs(ci): note immutable-release dependency on the release job (#481) #482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,6 +655,14 @@ jobs:
# disagrees with the manifest BEFORE any binary builds; `e2e` includes the
# (blocking) Windows arm, so a tag won't release unless Windows e2e is green.
needs: [check, nix-package, e2e, test-macos, test-windows, version-consistency]
# This repo has GitHub immutable releases ENABLED: publishing a release locks
# its tag + assets (they can't be added/modified/deleted afterward). That
# REQUIRES the reusable workflow to create the release as a draft, attach all
# assets, then publish as the final step — which @v10 does (see
# Zondax/_workflows#110). Do NOT pin back to a tag predating that change, or
# the post-publish asset uploads will be rejected and releases will break. The
# `release: published` event package-publish.yml triggers on still fires (from
# the publish transition at the end of the `Upload release assets` job).
uses: zondax/_workflows/.github/workflows/_release-rust.yml@v10
with:
binary_name: kache
Expand Down
Loading