feat(renderer): render meteors beside content#139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Risk Assessment
✅ Low: The changes are narrowly scoped to renderer-side meteor generation/rendering with targeted coverage added and no material correctness or regression risks found in the changed code.
Testing
npx vitest run src/renderer.test.tsnpx vitest run src/renderer.test.ts -t "Renderer meteors"Pipeline
Updates from git push no-mistakes
✅ **Rebase** - passed
Round 1 - passed ✅
🔧 **Review** - 1 issue found → auto-fixed (2)
Round 1 - found 1 warning
src/renderer.ts:308- When meteorFrequency maps to a count of 1, generateSideMeteorShower creates one left meteor and one right meteor, returning 2 meteors instead of honoring the requested count; use rightCount = count - leftCount or explicitly document that side showers intentionally exceed the count at the lowest frequency.Round 2 (auto-fix) - found 1 warning
src/renderer.ts:862- Side meteors are generated across the full available terminal height, but buildFrameCells only renders them for the content-side rows. On taller terminals, especially at low meteorFrequency, the generated meteor can start below the rendered side viewport and never appear; generate side meteors against the side/content viewport height or regenerate/filter before counting them.Round 3 (auto-fix) - passed ✅
✅ **Test** - passed
Round 1 - passed ✅
npx vitest run src/renderer.test.tsnpx vitest run src/renderer.test.ts -t "Renderer meteors"🔧 **Document** - 1 issue found → auto-fixed
Round 1 - found 1 info
README.md:39- The README embedsdocs/splash.pngas the product screenshot, but the renderer change adds meteors in the side gutters beside the main content area. The screenshot should be regenerated or replaced so the documented TUI preview reflects the new side-meteor rendering.Round 2 (auto-fix) - passed ✅
✅ **Lint** - passed
Round 1 - passed ✅
✅ **Push** - passed
Round 1 - passed ✅