build: switch project to pnpm#58
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
packageManager,pnpm-lock.yaml, andpnpm-workspace.yaml, removingpackage-lock.json.pnpm install --frozen-lockfileand run tooling through pnpm.Risk Assessment
✅ Low: The changes are narrowly scoped to switching install, CI, and lint helper commands from npm/npx to pnpm, with the prior npm fallback issue addressed and no material new risks found.
Testing
pnpm install --frozen-lockfilepnpm testPipeline
Updates from git push no-mistakes
⏭️ **intent** - skipped
Round 1 - passed ✅
✅ **Rebase** - passed
Round 1 - passed ✅
🔧 **Review** - 1 issue found → auto-fixed
Round 1 - found 1 warning
package.json:4- Switching the repository to pnpm leaves the no-mistakes lint helper on its npm fallback path when dependencies are missing, so clean local/gate runs for future TypeScript changes can ignorepnpm-lock.yamland the pnpm workspace supply-chain settings by runningnpm install --ignore-scripts; update that helper to install with pnpm or remove the npm fallback.Round 2 (auto-fix) - passed ✅
✅ **Test** - passed
Round 1 - passed ✅
pnpm install --frozen-lockfilepnpm test🔧 **Document** - 2 issues found → auto-fixed
Round 1 - found 2 warnings
README.md:226- The change switches the project development workflow from npm/npx to pnpm by adding packageManager "pnpm@11.1.1", replacing package-lock.json with pnpm-lock.yaml, updating CI/release installs topnpm install --frozen-lockfile, and changing the airlock lint script to usepnpm exec. The README Development section still documentsnpm run build,npm run dev,npm test, andnpm run test:watch, and the Session Hooks note still namesnpm run devas the development entrypoint. Update these developer commands to the pnpm equivalents so contributors follow the new package manager.CONTRIBUTING.md:36- The repository conventions still instruct contributors to runnpm run buildandnpm testbefore pushing, but this branch changes CI and local tooling to pnpm with a pnpm lockfile and packageManager declaration. Update the pre-push commands topnpm run buildandpnpm test, and consider noting pnpm as the required package manager in the repo conventions.Round 2 (auto-fix) - passed ✅
🔧 **Lint** - 2 issues found → auto-fixed
Round 1 - found 2 warnings
README.md:1- Prettier reported code style issues in this changed Markdown file. Runpnpm exec prettier --write README.mdto normalize formatting.pnpm-lock.yaml:1- Prettier reported code style issues in this changed YAML lockfile. Runpnpm exec prettier --write pnpm-lock.yamlto normalize formatting.Round 2 (auto-fix) - passed ✅
✅ **Push** - passed
Round 1 - passed ✅