Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: StepFormDialogのリファクタリング #5383

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore: StepFormDialogのリファクタリング #5383

wants to merge 4 commits into from
+36 −19

Conversation

schktjm
Copy link
Contributor

@schktjm schktjm commented Feb 13, 2025

関連URL

概要

  • メモ化など動きには影響しない細かいパフォーマンス系の修正

変更内容

  • decorators のメモ化
  • classNames のメモ化
  • propsにobjectリテラルを渡していた箇所を外だし
  • optionalな関数の実行の書き方修正

確認方法

  • storybook で確認してください！

@schktjm schktjm requested a review from a team as a code owner February 13, 2025 05:34
@schktjm schktjm requested review from AtsushiM and s-sasaki-0529 and removed request for a team February 13, 2025 05:34
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 13, 2025

Open in Stackblitz

npm i https://pkg.pr.new/kufu/smarthr-ui@5383

commit: 14dae4c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AtsushiM AtsushiM Awaiting requested review from AtsushiM AtsushiM is a code owner automatically assigned from kufu/group-dev-smarthr-ui-reviewers

@s-sasaki-0529 s-sasaki-0529 Awaiting requested review from s-sasaki-0529 s-sasaki-0529 is a code owner automatically assigned from kufu/group-dev-smarthr-ui-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@schktjm