chore: AccordionPanelの内部処理を整理 #5360
Open
+92
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
…e-refactoring-AccordionPanel
…e-refactoring-AccordionPanel
yagimushi
force-pushed
the
chore-refactoring-AccordionPanel
branch
from
ff2d85d to
c9aa384
Compare
AtsushiM
commented
Feb 13, 2025
Comment on lines
+115
to
+130
| const handleClick = useMemo(() => { | ||
| if (actualOnClickTrigger) { | ||
| if (actualOnClickProps) { | ||
| return (e: React.MouseEvent<HTMLButtonElement>) => { | ||
| actualOnClickTrigger(e) | ||
| actualOnClickProps(e) | ||
| } | ||
| } | ||
|
|
||
| if (onClickProps) { | ||
| const newExpandedItems = getNewExpandedItems( | ||
| expandedItems, | ||
| name, | ||
| !isExpanded, | ||
| expandableMultiply, | ||
| ) | ||
| onClickProps(mapToKeyArray(newExpandedItems)) | ||
| return actualOnClickTrigger | ||
| } else if (actualOnClickProps) { | ||
| return actualOnClickProps | ||
| } | ||
| }, [onClickTrigger, name, isExpanded, onClickProps, expandedItems, expandableMultiply]) | ||
|
|
||
| return undefined | ||
| }, [actualOnClickProps, actualOnClickTrigger]) |
There was a problem hiding this comment.
clickする度に無駄な呼び出しと判定が行われる可能性があったため、すべて事前にチェックするように修正しています
AtsushiM
requested review from
yt-ymmt and
nabeliwo
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法