Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: CIでは最新版のcorepackを使用する #5359

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

s-sasaki-0529
Copy link
Contributor

関連URL

refs: nodejs/corepack#612

概要

最新版手前のバージョンの corepack に不具合があり、pnpm install ができなくなっているため、CI では明示的に最新版の corepack を利用するように修正します。

変更内容

corepack prepare 前に最新版をインストールする。

確認方法

CI が通ればOK

最新版手前のバージョンの corepack に不具合があり、pnpm install ができなくなっているため
refs: nodejs/corepack#612
@s-sasaki-0529 s-sasaki-0529 self-assigned this Feb 3, 2025
Copy link

pkg-pr-new bot commented Feb 3, 2025

Open in Stackblitz

npm i https://pkg.pr.new/kufu/smarthr-ui@5359

commit: e5bf19e

@s-sasaki-0529 s-sasaki-0529 marked this pull request as ready for review February 3, 2025 01:16
@s-sasaki-0529 s-sasaki-0529 requested a review from a team as a code owner February 3, 2025 01:16
@s-sasaki-0529 s-sasaki-0529 requested review from moshisora and uknmr and removed request for a team February 3, 2025 01:16
@yamish123 yamish123 self-requested a review February 3, 2025 01:19
Copy link
Contributor

@yamish123 yamish123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@s-sasaki-0529 s-sasaki-0529 merged commit c0c50d1 into master Feb 3, 2025
13 checks passed
@s-sasaki-0529 s-sasaki-0529 deleted the use-latest-corepack branch February 3, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants