Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependency tar@<6.2.1 to v7 #5356

Merged
merged 6 commits into from
Feb 3, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 31, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
tar@<6.2.1 >=6.2.1 -> >=7.4.3 age adoption passing confidence

Release Notes

isaacs/node-tar (tar@<6.2.1)

v7.4.3

Compare Source

v7.4.2

Compare Source

v7.4.1

Compare Source

v7.4.0

Compare Source

v7.3.0

Compare Source

v7.2.0

Compare Source

v7.1.0

Compare Source

v7.0.1

Compare Source

v7.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - "after 8am and before 5pm every weekday" in timezone Asia/Tokyo, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the renovate label Jan 31, 2025
@renovate renovate bot requested a review from a team as a code owner January 31, 2025 05:41
@renovate renovate bot requested review from misako0927 and s-sasaki-0529 and removed request for a team January 31, 2025 05:41
Copy link

pkg-pr-new bot commented Jan 31, 2025

Open in Stackblitz

npm i https://pkg.pr.new/kufu/smarthr-ui@5356

commit: b38ae00

@s-sasaki-0529
Copy link
Contributor

脆弱性対応のその場しのぎの override くさい。
v7 が出てるなら、override 指定が不要な可能性もあるので試してみます。

@s-sasaki-0529 s-sasaki-0529 self-assigned this Feb 3, 2025
Copy link
Contributor Author

renovate bot commented Feb 3, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@s-sasaki-0529 s-sasaki-0529 marked this pull request as draft February 3, 2025 01:09
@@ -37,7 +37,6 @@
"react-dom": "^19.0.0",
"micromatch@<4.0.8": ">=4.0.8",
"cross-spawn@<7.0.5": ">=7.0.5",
"tar@<6.2.1": ">=6.2.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node-tar は依存の依存で入ってるパッケージでしたが、以前脆弱性通知があってバージョンをオーバーライドしていたように見えます。

今は override 外して自然に任せてインストールさせても脆弱性通知が出なくなったため、本PRではバージョンアップではなく override の削除だけに変えました。

@s-sasaki-0529 s-sasaki-0529 marked this pull request as ready for review February 3, 2025 01:22
@s-sasaki-0529 s-sasaki-0529 enabled auto-merge (squash) February 3, 2025 01:22
Copy link
Contributor

@s-sasaki-0529 s-sasaki-0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CIさえ通れば無問題なのでセルフアプルーブ

@s-sasaki-0529 s-sasaki-0529 merged commit d7b02ca into master Feb 3, 2025
14 of 15 checks passed
@s-sasaki-0529 s-sasaki-0529 deleted the renovate/tar<6.2.1-7.x branch February 3, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant