New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(AppHeader): elementAs, current, keyまわりのエラーを解消 #5355

Open

Qs-F wants to merge 1 commit into master from fix/appheader/navigation-error-elementas-key-dups

+25 −18

Contributor

Qs-F commented Jan 31, 2025 •

edited

Loading

関連URL

概要

HTML要素までelementAs, current等の存在しないpropsが渡っていてエラーが出ているので修正
FormattedMessageを通しているとkeyがすべて[object Object]になってしまうので修正

変更内容

elementAs, currentをpropsを渡すときにomitするように修正
FormattedMessageの中身がreact-innertextでは取れないので、indexを渡すように一時的に修正

確認方法

AppHeaderのStorybookで上記に関連するエラーが出ないこと


          fix(AppHeader): elementAs, current, keyまわりのエラーを解消

594d6b8

pkg-pr-new bot commented Jan 31, 2025

Open in Stackblitz

npm i https://pkg.pr.new/kufu/smarthr-ui@5355

commit: 594d6b8

Qs-F marked this pull request as ready for review

January 31, 2025 09:49

Qs-F requested a review from a team as a code owner

January 31, 2025 09:49

Qs-F requested review from oti and masa0527 and removed request for a team

January 31, 2025 09:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet