chore: ComboBoxのuseOptionsのロジックを整理する #5332
Open
+79
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagimushi
force-pushed
the
chore-refactoring-ComboBox-useOptions
branch
from
802117a to
0df395e
Compare
commit: |
AtsushiM
commented
Jan 25, 2025
Comment on lines
+29
to
+32
| const isSelected = useCallback( | ||
| (item: ComboBoxItem<T>) => selected !== null && selected.label === item.label, | ||
| [selected], | ||
| ) |
There was a problem hiding this comment.
isSelectedはoptionの数分実行されることになるため、配列チェックなどが多数実行されることになり、SingleComboBoxとMultiComboBoxで共通化するメリットが少なかったため、hookを分割しました
AtsushiM
commented
Jan 25, 2025
Comment on lines
-38
to
-41
| const getOptionId = useCallback( | ||
| (optionIndex: number) => `${optionIdPrefix}-${optionIndex}`, | ||
| [optionIdPrefix], | ||
| ) |
There was a problem hiding this comment.
メソッド化する意味が薄かったため削除しています
AtsushiM
commented
Jan 25, 2025
Comment on lines
+70
to
+80
| const addingOption: ComboBoxOption<T> | null = useMemo( | ||
| () => | ||
| creatable && inputValue && items.every((item) => item.label !== inputValue) | ||
| ? { | ||
| id: newItemId, | ||
| isNew: true, | ||
| selected: false, | ||
| item: { label: inputValue, value: inputValue }, | ||
| } | ||
| : null, | ||
| [inputValue, items, creatable, newItemId], |
There was a problem hiding this comment.
creatableがtrueになる可能性はかなり低く、nullになる可能性が高くなります。
別途メモ化することで他のmemoが更新される可能性が下がります
AtsushiM
commented
Jan 25, 2025
| return allOptions | ||
| } | ||
| return allOptions.filter(({ item: { label } }) => { | ||
| if (!inputValue) return true |
There was a problem hiding this comment.
filter内で処理する意味がないため、isFilteringDisabledと同時にチェックするようにしています
AtsushiM
requested review from
moshisora and
hiroki0525
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法