chore: DatePickerの内部処理を整理する #5329
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagimushi
force-pushed
the
chore-refactoring-DatePicker
branch
3 times, most recently
from
c38d089 to
35a48fe
Compare
yagimushi
force-pushed
the
chore-refactoring-DatePicker
branch
from
35a48fe to
8d05c8b
Compare
commit: |
AtsushiM
commented
Jan 24, 2025
Comment on lines
+17
to
+20
| // has no space on bottom side | ||
| inputRect.bottom + contentHeihgt > innerHeight && | ||
| // top side space bigger than bottom side | ||
| inputRect.top > innerHeight - inputRect.bottom |
There was a problem hiding this comment.
元々は変数化されていたのでifの実行前に余計な計算がされる可能性がありました。
if条件内に移動することで必要最小限の実行になるように修正しています
AtsushiM
commented
Jan 24, 2025
Comment on lines
+41
to
+49
| const style = useMemo(() => portal(), []) | ||
|
|
||
| const styleAttr = useMemo( | ||
| () => ({ | ||
| top: `${position.top}px`, | ||
| left: `${position.left}px`, | ||
| }), | ||
| [position.left, position.top], | ||
| ) |
There was a problem hiding this comment.
不必要にtailwindの実行がされる可能性があったため、memoを分割しています
AtsushiM
commented
Jan 24, 2025
| if (!containerRef.current) { | ||
| return | ||
| if (containerRef.current) { | ||
| setPosition(getPortalPosition(inputRect, containerRef.current.offsetHeight)) |
There was a problem hiding this comment.
直後の処理の条件の逆の早期returnになっていたため、整理しています
AtsushiM
commented
Jan 24, 2025
| const firstCalendarButton = calendarButtons[0] | ||
| const lastCalendarButton = calendarButtons[calendarButtons.length - 1] |
There was a problem hiding this comment.
直後のifで早期returnされる場合、利用されない変数だったため、位置を移動しています
AtsushiM
commented
Jan 24, 2025
|
|
||
| const switchCalendarVisibility = useCallback((isVisible: boolean) => { |
There was a problem hiding this comment.
明確にtrue, falseを渡す箇所が多く、依存関係の処理などがわかりにくくなっていたため、open, closeを明確に行う別関数を用意しました
AtsushiM
requested review from
oti and
yuzuru-akiyama
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法