chore: ActionDialogの内部処理を整理する #5324
Open
+166
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagimushi
force-pushed
the
chore-refactoring-ActionDialog
branch
from
84983bc to
703c0e3
Compare
commit: |
AtsushiM
commented
Jan 23, 2025
| @@ -24,7 +24,7 @@ export const ActionDialog: React.FC<Props & ElementProps> = ({ | |||
| onClickClose, | |||
| onPressEscape = onClickClose, | |||
| responseMessage, | |||
| actionDisabled = false, | |||
| actionDisabled, | |||
There was a problem hiding this comment.
最終的にButtonのdisabledに設定されるだけだったため、初期化の意味が薄く、削除しました
AtsushiM
commented
Jan 23, 2025
| if (!props.isOpen) { | ||
| return | ||
| if (props.isOpen) { | ||
| onClickClose() |
There was a problem hiding this comment.
早期returnしていますが
- 直後の処理の判定を逆転させているだけであり、理解が一手遅れる
- !とreturn分の処理が余計にかかる
というデメリットのほうが大きそうだったため調整しています
AtsushiM
commented
Jan 23, 2025
| onClickAction(onClickClose) | ||
| }, [onClickAction, onClickClose]) | ||
| const isRequestProcessing = responseMessage && responseMessage.status === 'processing' | ||
| const calcedResponseStatus = useMemo(() => { |
There was a problem hiding this comment.
responseMessageの判定が煩雑になっていたため、扱いやすい形に変換、memo化しています。
この処理は他のコンポーネントでもよくあるもののため、カスタムhookを別PRで作成予定です
AtsushiM
commented
Jan 23, 2025
Comment on lines
+24
to
+27
| const onClickOpen = useMemo( | ||
| () => (onClickTrigger ? () => onClickTrigger(open) : open), | ||
| [onClickTrigger, open], | ||
| ) |
There was a problem hiding this comment.
useCallbackではなくuseMemoにしています。
こうすることでどの場合でもonClickOpen実行時に行っているif判定を事前に行えます
AtsushiM
requested review from
moshisora and
hiroki0525
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法