chore: Dialog周辺コンポーネントのロジックを整理する #5318
Open
+101
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagimushi
force-pushed
the
chore-refactoring-DialogWrapper
branch
2 times, most recently
from
26197a7 to
a650f37
Compare
commit: |
yagimushi
force-pushed
the
chore-refactoring-DialogWrapper
branch
from
a650f37 to
2e54a1d
Compare
AtsushiM
commented
Jan 22, 2025
| onPressEscape = () => { | ||
| /* noop */ | ||
| }, | ||
| onPressEscape, |
There was a problem hiding this comment.
onPressEscapeが存在しない場合、そもそも実行する必要すらない箇所だったので、初期化を削除しました
AtsushiM
commented
Jan 22, 2025
| @@ -81,44 +71,39 @@ export const DialogContentInner: FC<DialogContentInnerProps & ElementProps> = ({ | |||
| className, | |||
| ...rest | |||
| }) => { | |||
| const { layoutStyleProps, innerStyle, backgroundStyle } = useMemo(() => { | |||
| const { layoutStyle, innerStyle, backgroundStyle } = useMemo(() => { | |||
There was a problem hiding this comment.
style属性とclass属性を同時にmemo化するメリットがない箇所だったので分割しました
AtsushiM
commented
Jan 22, 2025
| } | ||
| onPressEscape() | ||
| }, [isOpen, onPressEscape]), | ||
| useMemo(() => (onPressEscape && isOpen ? onPressEscape : undefined), [isOpen, onPressEscape]), |
There was a problem hiding this comment.
なるべくキャッシュが有効になるよう、onPressEscapeが存在し、かつ実行するひつようがあるときだけ参照渡しするようにしました
AtsushiM
commented
Jan 22, 2025
| @@ -25,8 +25,9 @@ const dialogHeader = tv({ | |||
| ], | |||
| }) | |||
|
|
|||
| export const DialogHeader: React.FC<Props> = ({ title, subtitle, titleTag, titleId }) => { | |||
| const style = dialogHeader() | |||
| export const DialogHeader = React.memo<Props>(({ title, subtitle, titleTag, titleId }) => { | |||
There was a problem hiding this comment.
DialogのHeaderはほぼ再レンダリングが不要な場合が多いと予想されるため、丸ごとmemo化しました
AtsushiM
commented
Jan 22, 2025
Comment on lines
+21
to
+22
| const onClickTrigger = useCallback(() => setActive(true), []) | ||
| const onClickClose = useCallback(() => setActive(false), []) |
There was a problem hiding this comment.
再生成が完全に不要な箇所だったため、memo化しています
AtsushiM
commented
Jan 22, 2025
| useEffect(() => { | ||
| if (!handleKeyPress) { |
There was a problem hiding this comment.
実行する必要が一切ない場合でもevent listnerが実行されるパターンが存在したため、早期終了を追加しました
AtsushiM
requested review from
misako0927 and
s-sasaki-0529
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法