Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to build with Go 1.23. #548

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Make it possible to build with Go 1.23. #548

merged 1 commit into from
Aug 6, 2024

Conversation

porridge
Copy link
Member

@porridge porridge commented Aug 5, 2024

What this PR does / why we need it:

Paraphrasing the function doc:

MainStart is not subject to the Go 1 compatibility document. It may change signature from release to release.

And so it did. This PR mimics what was done in hofstadter-io/hof#392

Fixes #546

This seems to work with both of:

[kuttl]$ GOTOOLCHAIN=go1.23rc2 go build ./...
[kuttl]$ GOTOOLCHAIN=go1.22 go build ./...

@porridge porridge requested a review from kensipe as a code owner August 5, 2024 15:29
@porridge porridge force-pushed the go-1-23-fix branch 2 times, most recently from 7affbc9 to 3bca337 Compare August 5, 2024 15:52
@porridge porridge changed the title Make is possible to build with Go 1.23. Make i possible to build with Go 1.23. Aug 5, 2024
@porridge porridge changed the title Make i possible to build with Go 1.23. Make it possible to build with Go 1.23. Aug 5, 2024
Copy link
Collaborator

@vladbologa vladbologa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@porridge porridge merged commit 0c46513 into main Aug 6, 2024
5 checks passed
@porridge porridge deleted the go-1-23-fix branch August 6, 2024 13:42
logan-bobo pushed a commit to logan-bobo/kuttl that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Build fails with Go 1.23 because of changed testing.testDeps
2 participants