-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotate container image with github source #391
Conversation
This seems pretty straight forward... @gberche-orange could you sign your commit for DCO? |
10c8d5a
to
6713f8a
Compare
Thanks @kensipe Sorry for the lack of DCO signoff from my commit originated from github web ui. This is now fixed. ps: I've rebased the commit (
So, hopefully my next commits won't be missing DCO again. |
It might be possible that if the |
thanks for patience... I've taken to long to get to this. I will review tomorrow this and the other PRs... really appreciate the contributions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\lgtm
Oh no, I clicked the button to refresh the branch and now the DCO check fails! 😭 |
97a6c16
to
9a42d10
Compare
closes kudobuilder#390 Signed-off-by: Guillaume Berche <[email protected]> Co-authored-by: Erik Godding Boye <[email protected]> Signed-off-by: Guillaume Berche <[email protected]>
9a42d10
to
ce0a883
Compare
What this PR does / why we need it:
Fixes #390