Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve renovate config #1258

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Conversation

ksimon1
Copy link
Member

@ksimon1 ksimon1 commented Jan 31, 2025

What this PR does / why we need it:
feat: ignore packages in vendor folder

Renovate identified some other dependencies (e.g. bazel) in vendor folder.
This caused incorrect PRs which bumped bazel dep, without proper update
of go.mod file

fix: replace matchPackagePatterns with matchPackageNames
This change was adviced by triggered renovate run. The matchPackagePatterns attribute is probably deprecated - renovatebot/renovate#28602

 WARN: Config needs migrating
       "configType": "RENOVATE_CONFIG",
       "originalConfig": {
         "$schema": "https://docs.renovatebot.com/renovate-schema.json",
         "baseBranches": [
           "main",
           "/^release-v(([1-9]+\\.([0-9]+))|(0\\.([1-9][0-9]{2,}|[2-9][0-9]|1[6-9])))$/"
         ],
         "prConcurrentLimit": 3,
         "lockFileMaintenance": {"enabled": false},
         "postUpdateOptions": ["gomodTidy"],
         "labels": ["release-note-none"],
         "extends": [":gitSignOff"],
         "packageRules": [
           {
             "groupName": "all dependencies",
             "groupSlug": "all",
             "enabled": false,
             "matchPackagePatterns": ["*"]
           }
         ],
         "vulnerabilityAlerts": {"enabled": true},
         "osvVulnerabilityAlerts": true,
         "assigneesFromCodeOwners": true,
         "separateMajorMinor": true,
         "ignorePaths": ["**/vendor/**"]
       },
       "migratedConfig": {
         "$schema": "https://docs.renovatebot.com/renovate-schema.json",
         "baseBranches": [
           "main",
           "/^release-v(([1-9]+\\.([0-9]+))|(0\\.([1-9][0-9]{2,}|[2-9][0-9]|1[6-9])))$/"
         ],
         "prConcurrentLimit": 3,
         "lockFileMaintenance": {"enabled": false},
         "postUpdateOptions": ["gomodTidy"],
         "labels": ["release-note-none"],
         "extends": [":gitSignOff"],
         "packageRules": [
           {
             "groupName": "all dependencies",
             "groupSlug": "all",
             "enabled": false,
             "matchPackageNames": ["*"]
           }
         ],
         "vulnerabilityAlerts": {"enabled": true},
         "osvVulnerabilityAlerts": true,
         "assigneesFromCodeOwners": true,
         "separateMajorMinor": true,
         "ignorePaths": ["**/vendor/**"]

Release note:

NONE

Renovate identified some other dependencies (e.g. bazel) in vendor folder.
This caused incorrect PRs which bumped bazel dep, without proper update
of go.mod file

Signed-off-by: Karel Simon <[email protected]>
This change was adviced by triggered renovate run.

Signed-off-by: Karel Simon <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 31, 2025
@jcanocan
Copy link
Contributor

Thanks for addressing this!
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2025
@akrejcir
Copy link
Collaborator

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2025
@kubevirt-bot kubevirt-bot merged commit c485385 into kubevirt:main Jan 31, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants