Merge pull request #287 from borod108/bugs/loglevel

Change default log level to be less verbose
kubevirt · Jan 25, 2022 · ec140d3 · ec140d3
2 parents bbbc02c + aa67672
commit ec140d3
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/controllers/ssp_controller.go b/controllers/ssp_controller.go
@@ -185,7 +185,7 @@ func (r *sspReconciler) Reconcile(ctx context.Context, req ctrl.Request) (res ct
 	}
 	sspRequest.Logger.V(1).Info("CR status updated")
 
-	sspRequest.Logger.V(1).Info("Reconciling operands...")
+	sspRequest.Logger.Info("Reconciling operands...")
 	reconcileResults, err := r.reconcileOperands(sspRequest)
 	if err != nil {
 		return handleError(sspRequest, err)
@@ -197,7 +197,7 @@ func (r *sspReconciler) Reconcile(ctx context.Context, req ctrl.Request) (res ct
 	if err != nil {
 		return ctrl.Result{}, err
 	}
-	sspRequest.Logger.V(1).Info("CR status updated")
+	sspRequest.Logger.Info("CR status updated")
 
 	if sspRequest.Instance.Status.Phase == lifecycleapi.PhaseDeployed {
 		common.SSPOperatorReconcilingProperly.Set(1)
@@ -412,7 +412,7 @@ func (r *sspReconciler) reconcileOperands(sspRequest *common.Request) ([]common.
 		sspRequest.Logger.V(1).Info(fmt.Sprintf("Reconciling operand: %s", operand.Name()))
 		reconcileResults, err := operand.Reconcile(sspRequest)
 		if err != nil {
-			sspRequest.Logger.V(1).Info(fmt.Sprintf("Operand reconciliation failed: %s", err.Error()))
+			sspRequest.Logger.Info(fmt.Sprintf("Operand reconciliation failed: %s", err.Error()))
 			return nil, err
 		}
 		allReconcileResults = append(allReconcileResults, reconcileResults...)

diff --git a/internal/common/resource.go b/internal/common/resource.go
@@ -171,7 +171,7 @@ func (r *reconcileBuilder) Reconcile() (ReconcileResult, error) {
 
 	res, err := r.createOrUpdateWithImmutableSpec(found, mutateFn)
 	if err != nil {
-		r.request.Logger.V(1).Info(fmt.Sprintf("Resource create/update failed: %v", err))
+		r.request.Logger.Info(fmt.Sprintf("Resource create/update failed: %v", err))
 		return ReconcileResult{}, err
 	}
 	if res == OperationResultDeleted || !found.GetDeletionTimestamp().IsZero() {

diff --git a/internal/operands/common-templates/reconcile.go b/internal/operands/common-templates/reconcile.go
@@ -92,7 +92,7 @@ func (c *commonTemplates) Reconcile(request *common.Request) ([]common.Reconcile
 	upgradingNow := isUpgradingNow(request)
 	for _, r := range reconcileTemplatesResults {
 		if !upgradingNow && (r.OperationResult == common.OperationResultUpdated) {
-			request.Logger.V(1).Info(fmt.Sprintf("Changes reverted in common template: %s", r.Resource.GetName()))
+			request.Logger.Info(fmt.Sprintf("Changes reverted in common template: %s", r.Resource.GetName()))
 			CommonTemplatesRestored.Inc()
 		}
 	}

diff --git a/main.go b/main.go
@@ -92,9 +92,7 @@ func main() {
 	flag.BoolVar(&enableLeaderElection, "leader-elect", false,
 		"Enable leader election for controller manager. "+
 			"Enabling this will ensure there is only one active controller manager.")
-	opts := zap.Options{
-		Development: true,
-	}
+	opts := zap.Options{}
 	opts.BindFlags(flag.CommandLine)
 	flag.Parse()