use upstream docker-registry-proxy and set proxy-connect timeouts #918
Conversation
Signed-off-by: Federico Gimenez <[email protected]>
Signed-off-by: Federico Gimenez <[email protected]>
kubevirt-bot
added
the
dco-signoff: yes
|
/cc @dhiller |
| secret: | ||
| secretName: docker-mirror-proxy | ||
| - name: storage | ||
| hostPath: |
There was a problem hiding this comment.
Is it required for the proxy to use hostpath? I mean, if the node goes down our cache won't work any more? Or do we have more than one cache node?
There was a problem hiding this comment.
You are completely right, when i created the docker-mirror-proxy deployment i just copied over the docker-mirror deployment, this hostPath setting was inherited from the old cluster constraints https://github.com/kubevirt/project-infra/blob/master/github/ci/prow/templates/mirror.yaml#L45-L47
I've just pushed changes to use a PVC instead, PTAL.
Signed-off-by: Federico Gimenez <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhiller The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
| value: "true" | ||
| - name: ALLOW_PUSH | ||
| value: "true" | ||
| - name: PROXY_CONNECT_TIMEOUT |
There was a problem hiding this comment.
Just noticed, this is a duplicate env var. Also elsewhere in PR #918.
These changes will prevent errors like https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/logs/publish-bootstrap-image/1354780192060477440 when pushing big layers through our proxy.
I've also taken the opportunity to switch to the upstream docker-registry-proxy image now that rpardini/docker-registry-proxy#70 is fixed and our previous upstream PRs have already landed.
Finally, I've added the proxy deployment to the automated prow-deploy, was missing there.
Signed-off-by: Federico Gimenez [email protected]