Repository navigation
🌱 ci: add hive-action-smoke workflow_dispatch for hive v6 readiness exercise - #24484
Conversation
…xercise Copy of hivecommons/hive's v6 smoke workflow, pinned to the v6 composite action, so the comment-relay transport can run in a repository that console's hive manages. Dispatch-only. Refs hivecommons/hive#9700, #24483. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🐝 Hi @clubanderson! I'm Trusted users — org members and contributors with write access — can mention Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies. |
|
👋 Hey @clubanderson — thanks for opening this PR!
This is an automated message. |
✅ Deploy Preview for kubestellarconsole canceled.
|
1 similar comment
✅ Deploy Preview for kubestellarconsole canceled.
|
There was a problem hiding this comment.
🟢 Approval recommended
The dispatch-only workflow matches the pinned action’s interface and exercise requirements, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Adds a manually dispatched smoke workflow for the hive v6 readiness exercise without changing existing CI.
Changes:
- Pins the hive action to a specific commit and configures comment or OIDC dispatch.
- Defaults the relay handle to
hivecommons-hiveand validates OIDC receipt output.
| File | Description |
|---|---|
.github/workflows/hive-action-smoke.yml |
Adds manual status relay and OIDC receipt checks. |
Review effort: Balanced
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
|
Post-merge build verification passed ✅ Both Go and frontend builds compiled successfully against merge commit |
There was a problem hiding this comment.
Trust-surface change — routing to a maintainer for an explicit decision. Code itself reads safe; the decision is about granting a third-party action write tokens in this repo.
What I verified in .github/workflows/hive-action-smoke.yml (the only file, +80/−0):
- Dispatch-only: triggers solely on
workflow_dispatch(line 7); it can never run from a PR or push, so untrusted forks cannot invoke it. - Permissions: the job gets
id-token: write,issues: write,pull-requests: write(lines 46–49). That is the minimum the stated comment/OIDC transports need, but it does hand an issue/PR-write token and an OIDC identity for this repo to an external action. - Pinned:
hivecommons/hive/.github/actions/hive@05316797e4…is a full-SHA pin (line 58), not a mutable tag. I could not independently verify the SHA's contents (that repo is outside my review scope). - No injection path: inputs flow only into
with:parameters; the onerun:step reads the action output viaenv(HIVE_RECEIPT, lines 72–75) rather than inline interpolation, so no shell-injection from inputs. - The header comment says this mirrors hivecommons/hive's own smoke workflow for the hive#9700 v6 readiness exercise, and the diff matches that stated purpose — no unrelated changes.
Question for a maintainer (one sentence): do you accept adding a manually-dispatched workflow that gives the SHA-pinned external hivecommons/hive action issues: write, pull-requests: write, and id-token: write in kubestellar/console for the v6 readiness exercise — and if yes, should it be removed after the exercise concludes?
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
Adds
.github/workflows/hive-action-smoke.yml, a dispatch-only copy of hivecommons/hive's v6 smoke workflow pinned tohivecommons/hive/.github/actions/hive@0531679(v6 head), with the relay handle defaulting tohivecommons-hive.Why: the hive v6 readiness live exercise (hivecommons/hive#9700 → hivecommons/hive#7563) needs the
workflow_dispatchcomment relay to run in a repository that console's hive manages. The relay posts@hivecommons-hive status …on the issue given as input (#24483 for the exercise).No effect on existing CI; the workflow only runs on manual dispatch.