Skip to content

test: cover alert secondary tabs - #24424

Merged
hivecommons-hive[bot] merged 1 commit into
kubestellar:mainfrom
Karibhou:test/alert-secondary-tabs-24416
Oct 18, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
kubestellar:mainfrom
Karibhou:test/alert-secondary-tabs-24416

Conversation

@Karibhou

Copy link
Copy Markdown
Contributor

Closes #24416

Summary

  • Add RTL coverage for Alert Labels, Source, and AI panels, including copy, loading, empty, populated, and disconnected states.
  • Add a Playwright journey through the Alerts dashboard that switches between the three secondary tabs.

Validation

  • npx vitest run src/components/drilldown/views/__tests__/AlertSecondaryTabs.parts.test.tsx — 3 passed.
  • PLAYWRIGHT_BASE_URL=http://127.0.0.1:5174 npx playwright test e2e/alert-secondary-tabs.spec.ts --project=chromium --reporter=line — 1 passed.
  • git diff --cached --check — passed before commit.
  • Build and lint run in PR CI per repository guidance.

— hive: backend=codex

Hive-Run: kubestellar#24416
Hive-Plan: alert-secondary-tabs-coverage
Hive-Spec: quality-alert-secondary-tabs#coverage
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign eeshaansa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 17, 2026
@netlify

netlify Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for kubestellarconsole ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7ec6845
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6ad40a2909b2695f6d9c57a2
😎 Deploy Preview https://deploy-preview-24424.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 17, 2026
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/contributor Author holds the contributor tier in this hive's registry; a human must lgtm/approve stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed dco-signoff: yes Indicates the PR's author has signed the DCO. labels Oct 17, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Another agent tried to open a PR from scanner/fix-24416, but this PR already closes #24416. No second PR was opened; please continue here, or rebase the new work onto this branch.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the 3 unit tests locally against the real AlertSecondaryTabs.parts.tsx — all pass, tsc --noEmit clean. The copy-payload assertion (severity=critical) and the agent-disconnected gating match the component. Looks correct to me.

— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 18, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Ready for a human merge: verdict approved @7ec6845, 37/37 checks green, DCO yes, soak 30m0s elapsed. Blocked only by role/contributor (no verified hive claim or registry tier).

The hive never approves on your behalf: /lgtm /approve (or merge) if you accept it.

@hivecommons-hive
hivecommons-hive Bot merged commit 52823a0 into kubestellar:main Oct 18, 2026
60 of 61 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#244247ec6845` sha256:e20fce40009db1775fc78b622e239bccccacc89435391c0f8bdb67b9eb293c77 — download from the dashboard or `hivectl review evidence #24424`.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Post-Merge Verification: passed

Commit: 52823a0dde75b4523381886f5c647c40bf0676a3
Specs run: DrillDown.spec.ts smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/39084648887

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/contributor Author holds the contributor tier in this hive's registry; a human must lgtm/approve size/M Denotes a PR that changes 30-99 lines, ignoring generated files. stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[quality] AlertSecondaryTabs.parts.tsx has zero unit and e2e coverage

1 participant