Skip to content

test: cover Operator drilldown detail tabs - #24421

Merged
hivecommons-hive[bot] merged 2 commits into
kubestellar:mainfrom
Karibhou:test/operator-detail-tabs-24418
Oct 18, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
kubestellar:mainfrom
Karibhou:test/operator-detail-tabs-24418

Conversation

@Karibhou

Copy link
Copy Markdown
Contributor

Closes #24418

Summary

  • Add direct RTL tests for the Operator CSV, CRD, and AI detail tabs, including populated, loading, empty, and action states.
  • Verify that switching tabs in OperatorDrillDown mounts the expected content and removes the previous tab's content.

Validation

  • cd web && ./node_modules/.bin/vitest run src/components/drilldown/views/OperatorDrillDown.detailTabs.parts.test.tsx src/components/drilldown/views/OperatorDrillDown.test.tsx (11 passed)
  • Build and lint are validated by CI per repository guidance.

— hive: backend=codex

Add direct tests for CSV, CRD, and AI detail states and verify tab switching through the drilldown.

Hive-Run: kubestellar#24418

Hive-Plan: issue kubestellar#24418 recommendation

Hive-Spec: issue kubestellar#24418#recommendation
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 17, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify

netlify Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for kubestellarconsole ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 88fd1bb
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6ad445c8447fa430a04cdb04
😎 Deploy Preview https://deploy-preview-24421.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 17, 2026
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/contributor Author holds the contributor tier in this hive's registry; a human must lgtm/approve stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed dco-signoff: yes Indicates the PR's author has signed the DCO. labels Oct 17, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran these locally against the real OperatorDrillDown.detailTabs.parts.tsx: all 11 tests (6 parts + 5 in OperatorDrillDown.test.tsx) pass, and tsc --noEmit is clean. The loading-vs-empty-state rerender checks and the disabled-diagnose gating match the component behavior I read. Looks correct to me.

— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 18, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Ready for a human merge: verdict approved @b51e339, 37/37 checks green, DCO yes, soak 30m0s elapsed. Blocked only by role/contributor (no verified hive claim or registry tier).

The hive never approves on your behalf: /lgtm /approve (or merge) if you accept it.

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing and removed stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 18, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Ready for a human merge: verdict approved @b51e339, 37/37 checks green, DCO yes, soak 30m0s elapsed. Blocked only by role/contributor (no verified hive claim or registry tier).

The hive never approves on your behalf: /lgtm /approve (or merge) if you accept it.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 18, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed dco-signoff: yes Indicates the PR's author has signed the DCO. stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing labels Oct 18, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

hive/awaiting-ci: branch synced with master to clear a stale merge-relay guard (earlier merge request exhausted while build-gate was still running; gate later passed). CI re-running on new head — sweep will merge when green and re-reviewed.


🐝 Hive Agent: scanner | Instance: hosted-kubestellar-console-4vkt | SHA: 7305443

— hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additive-only: one new parts test file plus one new case in the existing OperatorDrillDown.test.tsx. Verified OperatorDrillDown.detailTabs.parts.tsx exists at merge-base and exports OperatorCSVTab, OperatorCRDsTab, OperatorAITab as imported. The cases exercise the states that matter (loading vs empty vs populated, disabled-diagnose-while-disconnected, tab switching unmounting the previous tab's content), and the i18n/ConsoleAIIcon mocks follow the pattern already used in the sibling OperatorDrillDown.test.tsx. Coverage-gate and chromium shards are green.

Looks correct to me. (COMMENT only; approval left to a maintainer.)

— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 18, 2026
@hivecommons-hive hivecommons-hive Bot added stage/stalled In its current stage longer than expected stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing and removed stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/stalled In its current stage longer than expected labels Oct 18, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Ready for a human merge: verdict approved @88fd1bb, 30/30 checks green, DCO yes, soak 30m0s elapsed. Blocked only by role/contributor (no verified hive claim or registry tier).

The hive never approves on your behalf: /lgtm /approve (or merge) if you accept it.

@hivecommons-hive
hivecommons-hive Bot merged commit 24ee3e7 into kubestellar:main Oct 18, 2026
51 of 52 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#2442188fd1bb` sha256:40fb0ccc49bb6fe00c729b165604bf16fd3fa5d9015f7a2280a574ae9f583ab4 — download from the dashboard or `hivectl review evidence #24421`.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Post-Merge Verification: passed

Commit: 24ee3e7d0826b0af0e2a60eb5aad135e0af8423a
Specs run: DrillDown.spec.ts smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/39099572198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/contributor Author holds the contributor tier in this hive's registry; a human must lgtm/approve size/L Denotes a PR that changes 100-499 lines, ignoring generated files. stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[quality] OperatorDrillDown.detailTabs.parts.tsx has zero unit and e2e coverage

1 participant