Repository navigation
test: cover Operator drilldown detail tabs - #24421
hivecommons-hive[bot] merged 2 commits into
Conversation
Add direct tests for CSV, CRD, and AI detail states and verify tab switching through the drilldown. Hive-Run: kubestellar#24418 Hive-Plan: issue kubestellar#24418 recommendation Hive-Spec: issue kubestellar#24418#recommendation Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubestellarconsole ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Ran these locally against the real OperatorDrillDown.detailTabs.parts.tsx: all 11 tests (6 parts + 5 in OperatorDrillDown.test.tsx) pass, and tsc --noEmit is clean. The loading-vs-empty-state rerender checks and the disabled-diagnose gating match the component behavior I read. Looks correct to me.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
|
Ready for a human merge: verdict approved @b51e339, 37/37 checks green, DCO yes, soak 30m0s elapsed. Blocked only by The hive never approves on your behalf: |
|
Ready for a human merge: verdict approved @b51e339, 37/37 checks green, DCO yes, soak 30m0s elapsed. Blocked only by The hive never approves on your behalf: |
|
hive/awaiting-ci: branch synced with master to clear a stale merge-relay guard (earlier merge request exhausted while build-gate was still running; gate later passed). CI re-running on new head — sweep will merge when green and re-reviewed. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88 |
There was a problem hiding this comment.
Additive-only: one new parts test file plus one new case in the existing OperatorDrillDown.test.tsx. Verified OperatorDrillDown.detailTabs.parts.tsx exists at merge-base and exports OperatorCSVTab, OperatorCRDsTab, OperatorAITab as imported. The cases exercise the states that matter (loading vs empty vs populated, disabled-diagnose-while-disconnected, tab switching unmounting the previous tab's content), and the i18n/ConsoleAIIcon mocks follow the pattern already used in the sibling OperatorDrillDown.test.tsx. Coverage-gate and chromium shards are green.
Looks correct to me. (COMMENT only; approval left to a maintainer.)
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
|
Ready for a human merge: verdict approved @88fd1bb, 30/30 checks green, DCO yes, soak 30m0s elapsed. Blocked only by The hive never approves on your behalf: |
24ee3e7
into
kubestellar:main
✅ Post-Merge Verification: passedCommit: |
Closes #24418
Summary
OperatorDrillDownmounts the expected content and removes the previous tab's content.Validation
cd web && ./node_modules/.bin/vitest run src/components/drilldown/views/OperatorDrillDown.detailTabs.parts.test.tsx src/components/drilldown/views/OperatorDrillDown.test.tsx(11 passed)— hive: backend=codex