Repository navigation
refactor: split settings, cluster and terminal components - #24410
hivecommons-hive[bot] merged 3 commits into
Conversation
Preserve existing exports and behavior while extracting terminal lifecycle, cluster header/stats, KubeVirt settings, update install panels and the alert counter into focused modules below 400 lines. Closes kubestellar#24404 Hive-Run: kubestellar#24404 Hive-Plan: issue-24404-settings-clusters-terminal Hive-Spec: issue-24404#preserve-behavior-and-exports Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubestellarconsole ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@Karibhou this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
|
Ready for a human merge: verdict approved @4ce8119, 29/29 checks green, DCO yes, soak 30m0s elapsed. Blocked only by The hive never approves on your behalf: |
|
hive/awaiting-ci: all checks green, but the hive merge lane exhausted retries on head 4ce8119 while build-gate was still pending. A new commit from the author (even empty) or a maintainer merge will unstick it. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88 |
|
Ready for a human merge: verdict approved @4ce8119, 29/29 checks green, DCO yes, soak 30m0s elapsed. Blocked only by The hive never approves on your behalf: |
|
hive/awaiting-ci: branch synced with master to clear a stale merge-relay guard (earlier merge request exhausted while build-gate was still running; gate later passed). CI re-running on new head — sweep will merge when green and re-reviewed. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88 |
There was a problem hiding this comment.
Reviewed against the tree at merge-base, focusing on the highest-risk piece: the xterm/exec-session extraction.
web/src/components/terminal/usePodExecTerminal.tsis a verbatim move of the init, input/output wiring, exit handler, debounced resize, auto-connect, and focus effects fromPodExecTerminal.tsx— same constants, same effect ordering, same deps (including the intentional mount-only auto-connect). The hook returns everything the component consumes (PodExecTerminal.tsx:46-58).- Compatibility re-exports are all in place:
ClusterDetailModal.parts.tsx:7-8,UpdateSettingsForm.fields.tsx:274,LocalClustersSection.parts.tsx:9,AlertBadge.tsx:14. - New lifecycle tests and committed visual baselines back the move; visual regression, TTFI, and chromium shards are green.
Looks correct to me — behavior-preserving split, no semantic drift found. (COMMENT only; approval left to a maintainer.)
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
1805957
into
kubestellar:main
⏹️ Post-Merge Verification: cancelledCommit: |
Closes #24404
Split all five scanner-listed components below 400 lines while preserving their public props, exports, markup, and behavior:
usePodExecTerminal.Validation:
git diff --checkpasses.Testing limitation: the existing demo pod drilldown entered a render loop before mounting the exec terminal, so terminal browser verification used an isolated temporary harness instead of that integration path. The harness is not shipped.
— hive: backend=codex