Repository navigation
fix: set fsGroupChangePolicy OnRootMismatch for console data PVC - #24241
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <scanner@hive.kubestellar.io>
✅ Deploy Preview for kubestellarconsole canceled.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
👋 Hey @hivecommons-hive[bot] — thanks for opening this PR!
This is an automated message. |
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88 |
5c64077
ℹ️ Sentinel notice — informational; author is trusted (hive agent), merge is not blockedHive flagged this PR (author @hivecommons-hive[bot], head
Hive did not add the |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
|
Post-merge build verification passed ✅ Both Go and frontend builds compiled successfully against merge commit |
There was a problem hiding this comment.
Read the chart at the reviewed head (5c64077), not just the diff.
Verified correct:
deploy/helm/kubestellar-console/templates/deployment.yaml:39-40andtemplates/cronjob-db-backup.yaml:27-28both render.Values.podSecurityContextverbatim viatoYaml, sofsGroupChangePolicy: OnRootMismatchreaches both the console pod and the db-backup CronJob pod — the two writers sharing the data PVC. The field is a validPodSecurityContextkey (GA since k8s 1.23), and the placement atvalues.yaml:98sits alongside the existingfsGroup: 1001. Low risk: worst case it is a no-op.
Open question for whoever confirms the fix:
fsGroupChangePolicy controls the kubelet's recursive chown/chmod walk for fsGroup. The error quoted in the body — relabel failed ... lsetxattr: permission denied — is an SELinux xattr relabel, which is normally performed by the container runtime, not by the fsGroup walk. If the deploy-vllm-d failure is genuinely the runtime relabel, this flag may not stop it (the SELinux-side mitigation is the SELinuxMount/seLinuxChangePolicy path or avoiding the recursive relabel at the storage layer). I could not read the original kubelet log from here, so this is an open question, not a defect: please check whether the next deploy run actually passes before closing #24234/#24235 as fixed.
The change itself looks correct and safe to me either way.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
Closes #24235, Closes #24234
The deploy-vllm-d job fails because the kubelet attempts a recursive SELinux relabel/chown of the console data PVC and hits lsetxattr: permission denied on backup db files written by the db-backup CronJob. Setting fsGroupChangePolicy: OnRootMismatch skips the recursive pass when the root already matches, letting the pod start.
— hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88