[scanner] fix: nightly unit-test regression

[clubanderson]

Fixes #21083

Root cause

Two components initialised their cluster <select> state to "":

• CreateNamespaceModal: cluster state stayed "" so the Create button stayed disabled and agentFetch was never called → 4 tests failed.
• CanIChecker: INITIAL_FORM_STATE had cluster: "" and rendered a disabled placeholder <option>, giving 3 options instead of the expected 2, and clusterSelect.value was "" instead of the first cluster → 18 tests failed.

Fix

• CreateNamespaceModal: initialise useState with clusters[0] ?? "" so the first cluster is pre-selected on mount.
• CanIChecker: add a useEffect that dispatches SET_FIELD/cluster to the first available cluster when clusters load and none is selected yet; remove the now-redundant disabled placeholder <option> from the cluster dropdown.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign eeshaansa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for kubestellarconsole ready!

Name	Link
🔨 Latest commit	572e186
🔍 Latest deploy log	https://app.netlify.com/projects/kubestellarconsole/deploys/6a5df26ce7fa1e00088337d2
😎 Deploy Preview	https://deploy-preview-21318.console-deploy-preview.kubestellar.io
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[github-actions]

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

• Claude Code (Opus 4.5 / 4.6) — recommended
• GitHub Copilot
• Cursor
• Other AI coding assistants

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

---

This is an automated message.

[github-actions]

🐝 Hi @clubanderson! I'm kubestellar-hive[bot], an automation bot for this repo.

Trusted users — org members and contributors with write access — can mention @kubestellar-hive in a comment to trigger repo automation.
On issues, that mention queues an automated fix attempt. On pull requests, it records extra context for existing automation.
This is not an interactive Q&A bot, so mentions should be treated as requests for automation rather than a conversation.

Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies.

[github-actions]

✅ Test Coverage Check

All new source files in this PR have corresponding test files.

Checked web/src/hooks/ and web/src/components/ against origin/main.

[github-actions]

♿ Accessibility Audit (WCAG 2.1 AA)

✅ No WCAG 2.1 AA violations detected in audited routes.

---

Powered by axe-core. Target: WCAG 2.1 AA compliance.

[Copilot]

Pull request overview

Fixes a nightly unit-test regression caused by <select> controls initializing cluster to an empty string (""), which left UIs in an invalid/disabled state and caused tests to assert unexpected default values/options.

Changes:

• CreateNamespaceModal: initialize cluster state to the first available cluster (clusters[0] ?? '') so the Create flow is enabled by default.
• CanIChecker: auto-select the first cluster via useEffect when clusters load and none is selected, and remove the disabled placeholder option that was skewing option counts and default values.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
web/src/components/rbac/CanIChecker.tsx	Auto-selects the first cluster on load and removes the placeholder option to stabilize default selection and option counts in tests/UI.
web/src/components/namespaces/CreateNamespaceModal.tsx	Defaults the modal’s cluster state to the first provided cluster so Create isn’t blocked by an empty selection.

[github-actions]

Thank you for your contribution! Your PR has been merged.

Check out what's new:

• KubeStellar Console — Live multi-cluster dashboard
• Marketplace — Community extensions
• Knowledge Base — Troubleshooting and how-tos

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

[clubanderson]

[quality] 🚨 Conflicts with sibling PR #21299 — pick one strategy (comment mode; self-approve blocked)

Correct component-level fix — better strategy than the sibling #21299 which patched tests to accept a placeholder-default UI. Preferring this direction because "user must explicitly select an obvious default" is a UX regression, and the fix at source removes 22 test scaffolds too.

🚨 Merge-order conflict with sibling PR #21299

#21299 changes tests to expect .value === '' and renames test to 'initializes with cluster placeholder selected'. This PR changes the components to auto-select clusters[0], so .value === 'cluster-1'. Merging both breaks whichever tests match the not-current component state. Concretely:

• If this PR merges first, #21299's renamed test starts with no cluster selected will fail (.toBe('') vs actual 'cluster-a').
• If #21299 merges first, this PR's component change will trigger the same 22 failures they were trying to fix.

Recommendation: close #21299 (or reduce it to just the NamespaceAccessPanel.tsx file — the CreateNamespaceModal and CanIChecker test changes are obsoleted by this PR) and merge this one.

Fix correctness

CreateNamespaceModal — useState(clusters[0] ?? '') is correct. Two nits:

1. clusters prop can change (parent may re-fetch and pass a new list). Since useState initializer only runs on mount, if the modal is opened before clusters load (clusters === []), state stays '' and never picks up when clusters arrive. Fix: use the same useEffect pattern as CanIChecker, or memo the initial value more carefully:

   const [cluster, setCluster] = useState('')
   useEffect(() => {
     if (cluster === '' && clusters.length > 0) setCluster(clusters[0])
   }, [clusters, cluster])

   The current implementation is fine if clusters is always non-empty on mount, but the type signature (clusters: string[]) allows empty.

2. The disabled placeholder <option value="" disabled>Select a cluster</option> is still in the CreateNamespaceModal <select> (visible in the current source). With useState(clusters[0]) the placeholder becomes unreachable — user can never re-select "no cluster" once they've chosen. That's fine for a create-form. But: if clusters === [] on mount, the placeholder is the ONLY option, and the value stays '', and the button stays disabled. Correct — but consider showing an explicit "no clusters available" empty state instead.

CanIChecker — useEffect approach handles the async-load case. Correct. One nit:

3. Race between the auto-select effect and any URL-driven default (if there's ever a ?cluster=cluster-b query param, the effect will overwrite it as long as cluster === ''). Not currently a use case, but worth documenting.

Missing coverage

• No test locks the new "auto-select first cluster on load" behavior. Two tests would suffice:

  it('auto-selects first cluster when clusters load asynchronously', async () => {
    mockClusters = []
    const { rerender } = render(<CanIChecker />)
    expect((screen.getByTestId('can-i-cluster') as HTMLSelectElement).value).toBe('')
    mockClusters = [{ name: 'cluster-a' }, { name: 'cluster-b' }]
    rerender(<CanIChecker />)
    await waitFor(() => expect((screen.getByTestId('can-i-cluster') as HTMLSelectElement).value).toBe('cluster-a'))
  })
  
  it('CreateNamespaceModal pre-selects first cluster when clusters prop is non-empty', () => {
    render(<CreateNamespaceModal clusters={['cluster-x','cluster-y']} onClose={vi.fn()} onCreated={vi.fn()} />)
    const combos = screen.getAllByRole('combobox')
    expect((combos[0] as HTMLSelectElement).value).toBe('cluster-x')
  })

Bead filed. Not merging.

---

Filed by quality agent (ACMM L4/L6 — full mode)

[github-actions]

⏹️ Post-Merge Verification: cancelled

Commit: 9ec6f2ed0ca6742c00fca73e464a572523ac26a0
Specs run: NamespaceOverview.spec.ts smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/29733699405

[github-actions]

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit 9ec6f2ed0ca6742c00fca73e464a572523ac26a0.