Skip to content

[Auto-QA] Hardcoded user-facing strings need extraction #24548

Closed

Description

@clubanderson

Auto-QA [Localization]: Hardcoded Strings

Detected: 2026-10-22T07:42:41.958Z | Focus: Localization | Commit: 083122f | Run: View

Findings

### Hardcoded button labels

src/components/stellar/tests/WatchDetailModal.test.tsx:24: <button onClick={() => onResolve(watchId)}>Resolve
src/components/stellar/tests/WatchDetailModal.test.tsx:25: <button onClick={() => onDismiss(watchId)}>Dismiss
src/components/clusters/components/ClusterCardFull.test.tsx:58: RemoveClusterButton: () => Remove,
src/components/clusters/components/ClusterGrid.common.test.tsx:71: Action
src/components/clusters/components/ClusterGrid.common.test.tsx:88: Action
src/components/clusters/components/ClusterCardList.test.tsx:52: RemoveClusterButton: () => Remove,
src/components/ui/tests/Tooltip.test.tsx:10: Trigger
src/components/ui/tests/Tooltip.test.tsx:19: Trigger
src/components/ui/tests/Tooltip.test.tsx:68: Trigger
src/components/ui/tests/Tooltip.test.tsx:83: Trigger
src/components/ui/tests/Tooltip.test.tsx:139: Trigger

Suggested Improvements

  • Extract strings to a translations file (e.g., en.json)
  • Use a translation function like t("key") or <Trans>
  • Consider using react-i18next or similar library
  • Start with visible UI text: buttons, labels, headings

PR Guidance: Keep PRs small and focused. Smaller PRs have higher acceptance rates.


This issue was automatically created by the Auto-QA workflow during Localization focus day.

Activity

  1. added
    enhancementNew feature or request
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    triage/acceptedIndicates an issue or PR is ready to be actively worked on.
    auto-qaIssue detected by automated QA
    on Oct 22, 2026
  2. github-actions commented on Oct 22, 2026

    @github-actions
    Contributor

    🐝 Hi @clubanderson! I'm kubestellar-hive[bot], an automation bot for this repo.

    Trusted users — org members and contributors with write access — can mention @kubestellar-hive in a comment to trigger repo automation.
    On issues, that mention queues an automated fix attempt. On pull requests, it records extra context for existing automation.
    This is not an interactive Q&A bot, so mentions should be treated as requests for automation rather than a conversation.

    Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies.

  3. added and removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 22, 2026
  4. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 22, 2026
  5. hivecommons-hive commented on Oct 22, 2026

    @hivecommons-hive
    Contributor

    Triage: scanner false positive. Every cited line is in a test file (WatchDetailModal.test.tsx, ClusterCardFull.test.tsx, ClusterGrid.common.test.tsx, ClusterCardList.test.tsx, Tooltip.test.tsx). The strings are <button> literals inside mock components and fixtures ("Resolve", "Remove", "Trigger", "Action"). They are never rendered to users, and tests intentionally use literal strings to assert on. No production file is cited, so there is nothing to extract to i18n. Closing as not planned. The scanner should exclude *.test.* and __tests__/.


    🐝 Hive Agent: scanner | Instance: hosted-kubestellar-console-4vkt | SHA: 14f41ee

    — hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ai-fix-requestedauto-qaIssue detected by automated QAauto-qa:nfrenhancementNew feature or requesthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions