Repository navigation
[quality] SecretDataTab.parts.tsx has zero unit and e2e coverage #24415
Description
Finding
web/src/components/drilldown/views/SecretDataTab.parts.tsx (extracted in #24414 /
merged refactor commit 74774ba) renders the Secret drilldown's "Data" tab,
including the reveal/mask and copy controls for raw Secret values. It has zero
unit coverage and no end-to-end coverage.
Unit evidence: npx vitest run --coverage src/components/drilldown/views/__tests__/{AlertDrillDown,CRDDrillDown,ComplianceDrillDown,SecretDrillDown,KustomizationDrillDown}.test.tsx src/components/drilldown/views/OperatorDrillDown.test.tsx src/components/drilldown/RemediationConsole.test.tsx --coverage.include='src/components/drilldown/**' (run locally against main @ 74774ba) reports SecretDataTab.parts.tsx at 0% statements/lines — none of the parent SecretDrillDown tests exercise the "data" tab branch.
End-to-end evidence: e2e/DrillDown.spec.ts is the only e2e spec touching the drilldown modal; it asserts generic structural affordances (testid, tabs, close button) and never opens the Secret drilldown or its Data tab. No other e2e spec references SecretDataTab, SecretDrillDown, or the reveal/copy controls.
Since neither unit nor e2e tests exercise this file, this is a priority 1 (high) coverage gap — the component masks and reveals literal Secret values, so an untested regression here (e.g. a reveal-state bug that leaks value instead of the masked placeholder) would ship silently.
Recommendation
Add a focused RTL unit test for SecretDataTab covering:
- default masking of values (
••••••••••••••••placeholder) - reveal toggling only affects the targeted key
onCopyreceives the field-prefixed key and raw value- empty-state rendering when there are no data entries
- the "show all N keys" / "show less" toggle at >5 entries
Priority
- Impact: high (Secret values are reveal/mask-gated at this layer)
- Effort: low (presentational component, no external deps beyond lucide-react icons)
Filed by quality agent (ACMM L4/L6 — full mode)
🐝 Hive Agent: quality | Instance: hosted-kubestellar-console-4vkt | SHA: b9ff511
— hive: agent=quality backend=copilot model=claude-opus-4.7 copilot=1.0.88
Activity