Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split admin user creation and the rest resource creationg #1538

Open
wants to merge 1 commit into
base: release-3.1
Choose a base branch
from
Open

split admin user creation and the rest resource creationg #1538

wants to merge 1 commit into from

Conversation

simonyangcj
Copy link

when use script tool to deploy ks member cluster, some time the member cluster run initial-account.yaml after kubefed sync admin user from host cluster which will cause task "- name: KubeSphere | Initing account" totally skipped and no api-server and controller manage will be created. This patch will split admin user creatiion from other resource creation. It did test it -> working as expected :)

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: simonyangcj
To complete the pull request process, please assign rayzhou2017
You can assign the PR to them by writing /assign @rayzhou2017 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 11, 2021
@simonyangcj
Copy link
Author

/assign @rayzhou2017

@RolandMa1986
Copy link
Member

Hi @simonycj, we are going to replace the ks-core installation with a helm chart in a further release, including the admin account initial process. I'm not sure whether this issue can be recreated with Helm chart #1523. I will do more research about this issue.

@simonyangcj
Copy link
Author

@RolandMa1986 sounds good, its too complicate to tell recreate step for now becasue we have member cluster installation within a tool set, its rebuild every day :( , just some hint. When we registry the member cluster to host cluster right after run member cluster installation the problem might show again. We run kubectl logs ks-installer-774587dbf7-7f57x -n kubesphere-system > log to see the logs, seems like an ansible task has been skipped as following.
TASK [ks-core/prepare : KubeSphere | Initing account] ************************** changed: [skipped]
This will casue api-server and control-manager of member cluster not created at all. Hope this is help :)
So far i can live with my workaround, it`s good 2 no your movement, may be in future we can try your approach, let me no if anything i can do.

@swiftslee
Copy link
Contributor

when use script tool to deploy ks member cluster, some time the member cluster run initial-account.yaml after kubefed sync admin user from host cluster which will cause task "- name: KubeSphere | Initing account" totally skipped and no api-server and controller manage will be created. This patch will split admin user creatiion from other resource creation. It did test it -> working as expected :)

This task should be executed before the member cluster is managed by the host cluster. I don't understand why do you run this task after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes do-not-merge/hold size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants