Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubescape workload scan types #30

Merged
merged 5 commits into from
Aug 8, 2023
Merged

Kubescape workload scan types #30

merged 5 commits into from
Aug 8, 2023

Conversation

amirmalka
Copy link
Contributor

@amirmalka amirmalka commented Jul 27, 2023 •
edited
Loading

New types for saving Kubescape workload scan results (kubescape/kubescape#1300)

@github-actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: success
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

vladklokun
vladklokun reviewed Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@vladklokun vladklokun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the question about rules and controls, this looks good to me. Now I can use it to implement the types in the storage.

pkg/apis/softwarecomposition/types.go Outdated Show resolved Hide resolved
@amirmalka
Copy link
Contributor Author

@vladklokun so let's merge this :)

@vladklokun
Copy link
Collaborator

@vladklokun so let's merge this :)

I would prefer to merge only fully-featured changes into main. So once I complete wiring the types, I will add commits that fully implement the proposed type definitions to this PR. And we can merge into main.

Alternatively, we can re-target this branch to a feature branch and merge this PR right now. What do you say?

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Summary:

  • License scan: success
  • Credentials scan: success
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Summary:

  • License scan: success
  • Credentials scan: success
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@vladklokun vladklokun merged commit e465efd into main Aug 8, 2023
6 checks passed
@matthyx matthyx deleted the configuration-scanning-types branch October 1, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcohencyberarmor rcohencyberarmor rcohencyberarmor approved these changes

@vladklokun vladklokun Awaiting requested review from vladklokun

@matthyx matthyx Awaiting requested review from matthyx

@dwertent dwertent Awaiting requested review from dwertent

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amirmalka @vladklokun @rcohencyberarmor