feat: add summary objects #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladklokun
force-pushed
the
feat-add-summary-objects
branch
2 times, most recently
from
99200b7
to
7118cf4
Compare
This commit introduces manual type definitions for SBOM summaries. Signed-off-by: Vlad Klokun <[email protected]>
This commit finishes the changes needed to introduce a new API type: SBOM Summary. The new type acts as a lightweight beacon that will be created whenever an SBOM is created, so the Storage APIServer can avoid loading entire large SBOMs into memory when listing and serving Watch requests. Signed-off-by: Vlad Klokun <[email protected]>
Prior to this commit, introducing a "build" directory broke building a standalone binary using a Makefile. Because the "build" directory exists in the source tree, it made `make` think that the target already exists and is up-to-date, so it would not even try to build new binaries. This commit changes the target name and fixes the problem. Signed-off-by: Vlad Klokun <[email protected]>
This commit introduces manual type definition for vulnerability manifest summaries. Signed-off-by: Vlad Klokun <[email protected]>
… summaries This commit finishes the changes needed to introduce a new API type: Vulnerability Manifest Summary. The idea is the same as for the SBOM Summaries: lightweight indicators that make the Storage AA avoid loading large full objects into memory. Signed-off-by: Vlad Klokun <[email protected]>
vladklokun
force-pushed
the
feat-add-summary-objects
branch
from
7118cf4
to
b0e0b43
Compare
Signed-off-by: Vlad Klokun <[email protected]>
dwertent
approved these changes
Jun 26, 2023
matthyx
reviewed
Jun 26, 2023
| @@ -52,5 +52,5 @@ func NewREST(scheme *runtime.Scheme, storageImpl storage.Interface, optsGetter g | |||
| if err := store.CompleteWithOptions(options); err != nil { | |||
| return nil, err | |||
| } | |||
| return ®istry.REST{store}, nil | |||
| return ®istry.REST{Store: store}, nil | |||
There was a problem hiding this comment.
Kinda funny I found this with my LSP (go vet), since the linter did not even run on PR changes for me :)
matthyx
approved these changes
Jun 26, 2023
|
Summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes?
This commit:
builddirectory in the source tree.