add otel tracing and events #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Summary:
|
|
Summary:
|
|
Summary:
|
matthyx
force-pushed
the
telemetry
branch
2 times, most recently
from
9f67e91
to
8bb8f5c
Compare
Signed-off-by: Matthias Bertschy <[email protected]>
|
Summary:
|
1 similar comment
|
Summary:
|
Signed-off-by: Matthias Bertschy <[email protected]>
|
Summary:
|
vladklokun
reviewed
Jun 20, 2023
Comment on lines
+35
to
+38
| obj runtime.Object | ||
| meta *storage.ResponseMeta | ||
| rev int64 | ||
| data []byte |
There was a problem hiding this comment.
question: is the stale bool variable no longer needed? Why? Was it used before?
There was a problem hiding this comment.
I think it was never needed, golangci-lint was complaining.
| ) | ||
|
|
||
| func main() { | ||
| ctx := context.Background() | ||
| c, err := config.LoadConfig("/etc/config") |
There was a problem hiding this comment.
question: this would mean that the storage would need to have this config file present?
How would this be mapped in the Helm chart? How would we ensure this config exists? Should we provide an example?
There was a problem hiding this comment.
either we need the file present, or having some env set in order to know the customerID to enrich spans
kubescape/helm-charts#201
vladklokun
approved these changes
Jun 20, 2023
|
@dwertent should we release this to go along with the next Helm release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.