Http object type mb #146
Merged
Http object type mb #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Bertschy <[email protected]>
Signed-off-by: Matthias Bertschy <[email protected]>
Signed-off-by: Matthias Bertschy <[email protected]>
afek854
force-pushed
the
http-object-type-mb
branch
from
1c77ebd
to
a499d26
Compare
|
Summary:
|
|
Summary:
|
matthyx
reviewed
Sep 9, 2024
|
Summary:
|
matthyx
requested changes
Sep 9, 2024
afek854
force-pushed
the
http-object-type-mb
branch
from
963630c
to
259a619
Compare
afek854
force-pushed
the
http-object-type-mb
branch
from
259a619
to
59db408
Compare
|
Summary:
|
matthyx
approved these changes
Sep 11, 2024
| return existing | ||
| } | ||
|
|
||
| func convertPointerToValueSlice(m []*types.HTTPEndpoint) []types.HTTPEndpoint { |
There was a problem hiding this comment.
I think you can refactor without this, let's leave it for when you generalize
| @@ -49,7 +49,7 @@ func (a ApplicationProfileProcessor) PreSave(object runtime.Object) error { | |||
| } | |||
|
|
|||
| func deflateApplicationProfileContainer(container softwarecomposition.ApplicationProfileContainer) softwarecomposition.ApplicationProfileContainer { | |||
| endpoints, err := dynamicpathdetector.AnalyzeEndpoints(&container.Endpoints, dynamicpathdetector.NewPathAnalyzer()) | |||
| endpoints, err := dynamicpathdetector.AnalyzeEndpoints(&container.Endpoints, dynamicpathdetector.NewPathAnalyzer(100)) | |||
|
@afek854 use squash and merge pls |
afek854
added a commit
that referenced
this pull request
Sep 12, 2024
* WIP: http endpoints types * add generated code Signed-off-by: Matthias Bertschy <[email protected]> * WIP: added NetworkDirection * bump code generation script Signed-off-by: Matthias Bertschy <[email protected]> * WIP: Fixed generation script * WIP: Removed HTTPEndpoint deepcopy * WIP: Removed HTTPEndpoint from softwarecomposition client * WIP: Fixed generated files * WIP: Fixed types.go * WIP: Removed NetworkDirection * WIP: Removed logs * WIP: Move to string * WIP: Convert to string * WIP: Added consts * WIP: Multiple header values * WIP: Added Path & URL analyzing * WIP: removed debug logs * WIP: Handle duplicates url's * Http object type * add profobufs and fixes Signed-off-by: Matthias Bertschy <[email protected]> * WIP: Fixed typos & added benchmark tests * Added coverage & benchmark tests * WIP: Fixed bugs due tests * WIP: Added extra and tests * WIP: Added tests for extra * WIP: Removed Extra field * WIP: Code regeneration * WIP: Remove omitempty for bool valuie * WIP: Headers into RawMessage * WIP: Added GetHeaders * WIP: tidy * Removed typo & change log level * Added tests for endpoints * WIP: Added comment * Fixed application profile tests --------- Signed-off-by: Matthias Bertschy <[email protected]> Co-authored-by: Matthias Bertschy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, we do not accept changes directly against this repository. Please see
CONTRIBUTING.md for information on where and how to contribute instead.