Http object type #143
Http object type #143
Conversation
Signed-off-by: Matthias Bertschy <[email protected]>
Signed-off-by: Matthias Bertschy <[email protected]>
|
Summary:
|
afek854
force-pushed
the
http-object-type
branch
from
7570d2d
to
247343c
Compare
|
|
||
| type IsInternal string | ||
|
|
||
| const ( |
There was a problem hiding this comment.
I'm not convinced we need to do this... this sounds non idiomatic Go to me - do you have some reference for this pattern?
There was a problem hiding this comment.
Wdym by it? I did it because I could not transfer bool value (The bug we talked about)
There was a problem hiding this comment.
Damn, forgot about it. Still looking ugly 🫣
| SegmentName string | ||
| Count int | ||
| Children map[string]*SegmentNode | ||
| mutex sync.RWMutex |
| var newEndpoints []types.HTTPEndpoint | ||
| MergeDuplicateEndpoints(endpoints) | ||
| for _, endpoint := range *endpoints { | ||
| AnalyzeURL(endpoint.Endpoint, analyzer) |
There was a problem hiding this comment.
you don't use return value and error?
There was a problem hiding this comment.
In segment of the code no, because I would just skip errors.
We can talk about it
| } | ||
| } | ||
|
|
||
| func shallowChildrensCopy(src, dst *SegmentNode) { |
|
|
||
| func AnalyzeURL(urlString string, analyzer *PathAnalyzer) (string, error) { | ||
| if !strings.HasPrefix(urlString, "http://") && !strings.HasPrefix(urlString, "https://") { | ||
| urlString = "http://" + urlString |
There was a problem hiding this comment.
maybe we want to default to https?
There was a problem hiding this comment.
It does not matter as it is used only for parsing parsedURL, err := url.Parse(urlString)
|
|
||
| const dynamicIdentifier string = "<dynamic>" | ||
|
|
||
| const theshold = 100 |
|
I have started a new branch, rebased on my changes to main (some refactoring to use gRPC) so you might want to use this one instead: https://github.com/kubescape/storage/tree/http-object-type-mb |
afek854
force-pushed
the
http-object-type
branch
from
6fd10ed
to
2019ba4
Compare
Sorry, we do not accept changes directly against this repository. Please see
CONTRIBUTING.md for information on where and how to contribute instead.