Improvements #127
Draft
Improvements #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Bertschy <[email protected]>
Signed-off-by: Matthias Bertschy <[email protected]>
|
Summary:
|
1 similar comment
|
Summary:
|
Signed-off-by: Matthias Bertschy <[email protected]>
matthyx
commented
Jul 19, 2024
|
|
||
| cacheClient, err := cache.NewClient( | ||
| cache.ClientWithAdapter(memcached), | ||
| cache.ClientWithTTL(10*time.Minute), |
There was a problem hiding this comment.
obviously this needs to be set lower, or we should check how to invalidate cache
|
Summary:
|
slashben
reviewed
Aug 14, 2024
There was a problem hiding this comment.
I have looked into the http-cache package. My main concern is the lack of cache invalidation. I don't see it invalidates cache items on the PUSH/PUT/UPDATE/DELETE methods. Either we fork and implement this, or need to find another solution because this implementation leads to inconsistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.